Wrong division on epoch milliseconds

nekevss · jedel1043 · commit 98c9f2b1a583 · 2025-02-28T04:52:18.000Z
diff --git a/src/builtins/core/instant.rs b/src/builtins/core/instant.rs
@@ -226,7 +226,7 @@ impl Instant {
     /// Returns the `epochMilliseconds` value for this `Instant`.
     #[must_use]
     pub fn epoch_milliseconds(&self) -> i64 {
-        (self.as_i128() / 1_000_000) as i64
+        self.as_i128().div_euclid(1_000_000) as i64
     }
 
     /// Returns the `epochNanoseconds` value for this `Instant`.

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ impl Instant {`
`226`	`226`	/// Returns the `epochMilliseconds` value for this `Instant`.
`227`	`227`	`#[must_use]`
`228`	`228`	`pub fn epoch_milliseconds(&self) -> i64 {`
`229`		`- (self.as_i128() / 1_000_000) as i64`
	`229`	`+ self.as_i128().div_euclid(1_000_000) as i64`
`230`	`230`	`}`
`231`	`231`
`232`	`232`	/// Returns the `epochNanoseconds` value for this `Instant`.