Skip to content

Commit f1227dc

Browse files
committed
remove questions from code itself
1 parent 9a0482e commit f1227dc

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

src/builtins/core/duration.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -690,8 +690,6 @@ impl Duration {
690690
relative_to: Option<RelativeTo>,
691691
provider: &impl TimeZoneProvider,
692692
// Review question what is the return type of duration.prototye.total?
693-
// total seems to return floating point numbers, but the signature was orignally
694-
// returning a TemporalResult<i64>?? I changed this, but I'm not sure if this is correct.
695693
) -> TemporalResult<f64> {
696694
match relative_to {
697695
// 11. If zonedRelativeTo is not undefined, then

src/builtins/core/duration/normalized.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -303,10 +303,7 @@ struct NudgeRecord {
303303
expanded: bool,
304304
}
305305

306-
// TODO: Review question:
307-
// had to create a new nudgerecord that doesn't convert and store to i128 in nudge_calendar_unit(),
308-
// as well as a duplicate function to nudge_calendar_unit_f64() to make it work :/
309-
// Any suggestions on how to make it better?
306+
// TODO: Review question: Code needs to be refactored
310307
#[allow(dead_code)]
311308
struct NudgeRecordF64 {
312309
normalized: NormalizedDurationRecord,

0 commit comments

Comments
 (0)