File tree Expand file tree Collapse file tree 2 files changed +1
-6
lines changed
Expand file tree Collapse file tree 2 files changed +1
-6
lines changed Original file line number Diff line number Diff line change @@ -690,8 +690,6 @@ impl Duration {
690690 relative_to : Option < RelativeTo > ,
691691 provider : & impl TimeZoneProvider ,
692692 // Review question what is the return type of duration.prototye.total?
693- // total seems to return floating point numbers, but the signature was orignally
694- // returning a TemporalResult<i64>?? I changed this, but I'm not sure if this is correct.
695693 ) -> TemporalResult < f64 > {
696694 match relative_to {
697695 // 11. If zonedRelativeTo is not undefined, then
Original file line number Diff line number Diff line change @@ -303,10 +303,7 @@ struct NudgeRecord {
303303 expanded : bool ,
304304}
305305
306- // TODO: Review question:
307- // had to create a new nudgerecord that doesn't convert and store to i128 in nudge_calendar_unit(),
308- // as well as a duplicate function to nudge_calendar_unit_f64() to make it work :/
309- // Any suggestions on how to make it better?
306+ // TODO: Review question: Code needs to be refactored
310307#[ allow( dead_code) ]
311308struct NudgeRecordF64 {
312309 normalized : NormalizedDurationRecord ,
You can’t perform that action at this time.
0 commit comments