Run clippy on all targets

bobbobbio · bobbobbio · commit 349e1133d7b3 · 2025-02-15T17:33:44.000-08:00
diff --git a/library/src/lr35902_emulator/tests/blargg.rs b/library/src/lr35902_emulator/tests/blargg.rs
@@ -4,7 +4,7 @@ use super::{read_screen_message, read_test_rom};
 use crate::emulator_common::{MemoryAccessor, SimpleMemoryAccessor};
 use crate::lr35902_emulator::LR35902Emulator;
 
-fn load_rom(memory_accessor: &mut SimpleMemoryAccessor, rom: &Vec<u8>) {
+fn load_rom(memory_accessor: &mut SimpleMemoryAccessor, rom: &[u8]) {
     memory_accessor.memory[0..rom.len()].clone_from_slice(rom);
 }
 
diff --git a/presubmit b/presubmit
@@ -25,4 +25,4 @@ mkdir -p target/web_build
 
 ./pico/build.sh
 
-cargo clippy -- --deny "warnings"
+cargo clippy --all-targets -- --deny "warnings"

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ use super::{read_screen_message, read_test_rom};`
`4`	`4`	`use crate::emulator_common::{MemoryAccessor, SimpleMemoryAccessor};`
`5`	`5`	`use crate::lr35902_emulator::LR35902Emulator;`
`6`	`6`
`7`		`-fn load_rom(memory_accessor: &mut SimpleMemoryAccessor, rom: &Vec<u8>) {`
	`7`	`+fn load_rom(memory_accessor: &mut SimpleMemoryAccessor, rom: &[u8]) {`
`8`	`8`	`memory_accessor.memory[0..rom.len()].clone_from_slice(rom);`
`9`	`9`	`}`
`10`	`10`
Original file line number	Diff line number	Diff line change
`@@ -25,4 +25,4 @@ mkdir -p target/web_build`
`25`	`25`
`26`	`26`	`./pico/build.sh`
`27`	`27`
`28`		`-cargo clippy -- --deny "warnings"`
	`28`	`+cargo clippy --all-targets -- --deny "warnings"`