Validate domain patterns #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added isDomainName
|
Hi, I just stumbled across this enhancement and it is also relevant for me tbh to verify whether I'm working with a valid domain name. Is there any reason not to include this PR into the utils? |
|
Maintainers seem to be inactive. Better create your own fork or checkout mine. |
|
Sorry for the in-activity, the tests are failing atm for this branch. I'm happy to take this one in @gohumble but it should not break the default functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
I have added isDomainName function. This will validate the domain name using the isDomainName function from golangs DNS lib. So this should be very solid. This function does not have public scope. That's why I had to copy it.
I recognized the same issues as described in #12
This will also validate host names in emails (such as [email protected]). This is because of the stripURLParts call before checking the domain name.
[email protected] will not fail the validation.
Cheers