search: make sure to override previous results on completion

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 
-## [Smoother search and bug fixes] - 2024-12-14
+## [Search bug fix] - 2024-12-19
+
+- **search**: Fix some issues where results do not reset when a search returns no results or fails.
+
+## [Smoother search and bug fixes](https://github.com/raycast/extensions/pull/15862) - 2024-12-14
 
 - **search**: Opening a query in browser now correctly preserves the selected pattern type from the pattern type selector.
 - **search**: Typing during ongoing searches should feel less jittery, as the suggestion view is now less likely to show up randomly.

src/hooks/search.tsx

@@ -164,9 +164,19 @@ export function useSearch(src: Sourcegraph, maxResults: number) {
             };
           });
         },
+        onDone: () => {
+          setState((oldState) => {
+            if (oldState.isPreviousResults) {
+              return { ...oldState, results: [], isPreviousResults: false };
+            }
+            return oldState;
+          });
+        },
       });
     } catch (error) {
       ExpandableToast(push, "Unexpected error", "Search failed", String(error)).show();
+      // Reset the search state
+      setState((oldState) => ({ ...oldState, loading: false, results: [], isPreviousResults: false }));
     } finally {
       setState((oldState) => ({
         ...oldState,

src/sourcegraph/stream-search/index.ts

@@ -37,6 +37,7 @@ export interface SearchHandlers {
   onSuggestions: (suggestions: Suggestion[], top: boolean) => void;
   onAlert: (alert: Alert) => void;
   onProgress: (progress: Progress) => void;
+  onDone: () => void;
 }
 
 // Copied by hand from https://sourcegraph.sourcegraph.com/search?q=repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+f:graphql+%22enum+SearchPatternType+%7B%22&patternType=keyword&case=yes&sm=0
@@ -232,6 +233,9 @@ export async function performSearch(
     });
 
     // done indicator
-    stream.addEventListener("done", resolveStream);
+    stream.addEventListener("done", () => {
+      handlers.onDone();
+      resolveStream();
+    });
   });
 }