Skip to content

Commit c3fd66a

Browse files
committed
test: update actual_service tests to patch _build_ruleset instead of get_ruleset
1 parent 12c5418 commit c3fd66a

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

tests/test_actual_service.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ class TestActualService(unittest.TestCase):
1414
def setUp(self):
1515
self.service = ActualService()
1616

17-
@patch("services.actual_service.get_ruleset")
17+
@patch.object(ActualService, "_build_ruleset")
1818
@patch("services.actual_service.create_transaction")
1919
@patch("services.actual_service.Actual")
20-
def test_add_transactions_success(self, mock_actual, mock_create_transaction, mock_get_ruleset):
20+
def test_add_transactions_success(self, mock_actual, mock_create_transaction, mock_build_ruleset):
2121
# Arrange
2222
mock_actual_instance = MagicMock()
2323
mock_actual.return_value.__enter__.return_value = mock_actual_instance
2424
mock_ruleset = MagicMock()
25-
mock_get_ruleset.return_value = mock_ruleset
25+
mock_build_ruleset.return_value = mock_ruleset
2626

2727
transactions = [
2828
Transaction(
@@ -111,18 +111,18 @@ def test_build_import_id_is_deterministic_and_normalized(self):
111111
self.assertEqual(import_id_one, import_id_two)
112112
self.assertTrue(import_id_one.startswith("ID-"))
113113

114-
@patch("services.actual_service.get_ruleset")
114+
@patch.object(ActualService, "_build_ruleset")
115115
@patch("services.actual_service.get_payees")
116116
@patch("services.actual_service.create_transaction")
117117
@patch("services.actual_service.Actual")
118118
def test_add_transactions_duplicate_payee_fallback(
119-
self, mock_actual, mock_create_transaction, mock_get_payees, mock_get_ruleset
119+
self, mock_actual, mock_create_transaction, mock_get_payees, mock_build_ruleset
120120
):
121121
# Arrange
122122
mock_actual_instance = MagicMock()
123123
mock_actual.return_value.__enter__.return_value = mock_actual_instance
124124
mock_ruleset = MagicMock()
125-
mock_get_ruleset.return_value = mock_ruleset
125+
mock_build_ruleset.return_value = mock_ruleset
126126

127127
duplicate_payee_error = MultipleResultsFound("Multiple rows were found when one or none was required")
128128
successful_transaction = MagicMock()
@@ -168,16 +168,16 @@ def test_add_transactions_duplicate_payee_fallback(
168168
mock_ruleset.run.assert_called_once_with([successful_transaction])
169169
mock_actual_instance.commit.assert_called_once()
170170

171-
@patch("services.actual_service.get_ruleset")
171+
@patch.object(ActualService, "_build_ruleset")
172172
@patch("services.actual_service.create_transaction")
173173
@patch("services.actual_service.Actual")
174174
def test_add_transactions_uses_stable_import_id_for_replayed_transaction(
175-
self, mock_actual, mock_create_transaction, mock_get_ruleset
175+
self, mock_actual, mock_create_transaction, mock_build_ruleset
176176
):
177177
mock_actual_instance = MagicMock()
178178
mock_actual.return_value.__enter__.return_value = mock_actual_instance
179179
mock_ruleset = MagicMock()
180-
mock_get_ruleset.return_value = mock_ruleset
180+
mock_build_ruleset.return_value = mock_ruleset
181181

182182
settings.account_mappings = {"Test Account": "actual-account-id"}
183183
settings.actual_default_account_id = "default-account-id"

0 commit comments

Comments
 (0)