minimumApprovals is never checked

[stefdelec]

I have my config as:

updateBranch: true
deleteBranchAfterMerge: true
reportStatus: true

minApprovals:
  CONTRIBUTOR: 1
  OWNER: 1
  COLLABORATOR: 1
blockingLabels:
  - wip

And

I don't understand why it is not checked.

[stefdelec]

I even tried

[AnandChowdhary]

@bobvanderlinden I'm having the same issue, but I'm certain I'm doing something wrong. Any chance you have a few moments to help us reproduce, triage, and fix this? Thanks a ton for a great project!

[bobvanderlinden]

What is the exact role of the reviewer? You can check this using:

query { 
  repository(name: ***, owner: ***) {
    pullRequest(number: 123) {
      reviews(first: 1) {
        nodes {
          authorAssociation
        }
      }
    }
  }
}

Is it one of:

probot-auto-merge/src/association.ts

Lines 4 to 10 in 3da1900

	CommentAuthorAssociation.NONE,
	CommentAuthorAssociation.FIRST_TIMER,
	CommentAuthorAssociation.FIRST_TIME_CONTRIBUTOR,
	CommentAuthorAssociation.CONTRIBUTOR,
	CommentAuthorAssociation.COLLABORATOR,
	CommentAuthorAssociation.MEMBER,
	CommentAuthorAssociation.OWNER

That said, I would also recommend checking out GitHub merge queues. It is in beta, but covers most use-cases of probot-auto-merge without self-hosting an application.

[AnandChowdhary]

Thanks @bobvanderlinden!

The API response says `CONTRIBUTOR`

{
  "data": {
    "repository": {
      "pullRequest": {
        "reviews": {
          "nodes": [
            {
              "authorAssociation": "CONTRIBUTOR"
            }
          ]
        }
      }
    }
  }
}

And the `github/auto-merge.yml` says 1 for contributor:

updateBranch: true
deleteBranchAfterMerge: true
reportStatus: true
minApprovals:
  OWNER: 0
  MEMBER: 1
  COLLABORATOR: 1
  CONTRIBUTOR: 1
  FIRST_TIMER: 1
  FIRST_TIME_CONTRIBUTOR: 1
  NONE: 1
blockingLabels:
  - blocked
mergeCommitMessage: "{title} (#{number})"

And here's me approving :)