update tests

Author: bodintsov

osf/models/mixins.py

@@ -1584,7 +1584,7 @@ def add_unregistered_contributor(
         # Create a new user record if you weren't passed an existing user
         contributor = existing_user if existing_user else OSFUser.create_unregistered(fullname=fullname, email=email)
 
-        if existing_user is None and has_domain_in_user_fields_for_names(contributor):
+        if has_domain_in_user_fields_for_names(contributor):
             raise ValidationError('Invalid personal information.')
 
         try:

osf_tests/test_user.py

@@ -2090,19 +2090,19 @@ def test_validate_domain_fields_unregistered_contributor(self):
         project = ProjectFactory(creator=self.user)
         with pytest.raises(ValidationError):
             project.add_unregistered_contributor(
-                fullname='google.com',
-                email='spammy@example.com',
+                fullname='Visit google.com for fun spam action',
+                email='spammy@cos.io',
                 auth=Auth(self.user),
                 notification_type=False,
             )
-        assert not OSFUser.objects.filter(username='spammy@example.com').exists()
+        assert not OSFUser.objects.filter(username='spammy@cos.io').exists()
 
     def test_validate_domain_fields_notable_domain_unregistered_contributor(self):
         NotableDomain.objects.get_or_create(domain='google.com', note=NotableDomain.Note.IGNORED)
         project = ProjectFactory(creator=self.user)
         contributor = project.add_unregistered_contributor(
             fullname='google.com',
-            email='notspammy@example.com',
+            email='notspammy@cos.io',
             auth=Auth(self.user),
             notification_type=False,
         )
@@ -2112,7 +2112,7 @@ def test_validate_domain_fields_no_domain(self):
         project = ProjectFactory(creator=self.user)
         contributor = project.add_unregistered_contributor(
             fullname='Sandhya N.Sathesh',
-            email='sandhya@example.com',
+            email='sandhya@cos.io',
             auth=Auth(self.user),
             notification_type=False,
         )

osf_tests/test_validators.py

@@ -168,7 +168,7 @@ def test_has_domain_in_user_fields(user_data):
             'fullname': 'Judith Sarah',
             'given_name': 'Judith',
             'family_name': 'Preuss',
-            'middle_names': 'https://www.google.com',
+            'middle_names': 'Visit https://www.google.com today',
             'suffix': 'M.Sc.',
         },
         {