Skip to content

Commit 2c5d304

Browse files
authored
Merge pull request #853 from Gliese852/fix-wrong-signals
Connect to signals of the shown window
2 parents a2eabc9 + bcde184 commit 2c5d304

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

howdy-gtk/src/onboarding.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ def __init__(self):
1919
# Make the class a GTK window
2020
gtk.Window.__init__(self)
2121

22-
self.connect("destroy", self.exit)
23-
self.connect("delete_event", self.exit)
24-
2522
self.builder = gtk.Builder()
2623
self.builder.add_from_file(paths_factory.onboarding_wireframe_path())
2724
self.builder.connect_signals(self)
@@ -30,6 +27,9 @@ def __init__(self):
3027
self.slidecontainer = self.builder.get_object("slidecontainer")
3128
self.nextbutton = self.builder.get_object("nextbutton")
3229

30+
self.window.connect("destroy", self.exit)
31+
self.window.connect("delete_event", self.exit)
32+
3333
self.slides = [
3434
self.builder.get_object("slide0"),
3535
self.builder.get_object("slide1"),
@@ -320,7 +320,7 @@ def show_error(self, error, secon=""):
320320
dialog.destroy()
321321
self.exit()
322322

323-
def exit(self, widget=None):
323+
def exit(self, widget=None, context=None):
324324
"""Cleanly exit"""
325325
gtk.main_quit()
326326
sys.exit(0)

howdy-gtk/src/window.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ def __init__(self):
2323
# Make the class a GTK window
2424
gtk.Window.__init__(self)
2525

26-
self.connect("destroy", self.exit)
27-
self.connect("delete_event", self.exit)
28-
2926
self.builder = gtk.Builder()
3027
self.builder.add_from_file(paths_factory.main_window_wireframe_path())
3128
self.builder.connect_signals(self)
@@ -35,6 +32,9 @@ def __init__(self):
3532
self.modellistbox = self.builder.get_object("modellistbox")
3633
self.opencvimage = self.builder.get_object("opencvimage")
3734

35+
self.window.connect("destroy", self.exit)
36+
self.window.connect("delete_event", self.exit)
37+
3838
# Init capture for video tab
3939
self.capture = None
4040

@@ -105,7 +105,7 @@ def on_about_link(self, label, uri):
105105
status, output = subprocess.getstatusoutput(["sudo -u " + user + " timeout 10 xdg-open " + uri])
106106
return True
107107

108-
def exit(self, widget, context):
108+
def exit(self, widget=None, context=None):
109109
"""Cleanly exit"""
110110
if self.capture is not None:
111111
self.capture.release()

0 commit comments

Comments
 (0)