Shouldn't define a function in `vim` module

[brianhuster]

The vim module is for Neovim's built-in functions, so I don't think it's a good idea to create function for it. What if Neovim actually add a function vim.snippet.add later, that has different spec than the one used in your NativeVim? Then users will have to update or remove it, if they don't want it to even break plugins that use it

As an user, I would recommend user-config-defined functions to live in user or config module instead.

[boltlessengineer]

Fair point!

Though I want to keep everything simple. Main goal of NativeVim is to serve as a Neovim-native configuration template rather than building whole new system on top of it like other distros do.

Having multiple modules to deal with snippets might confuse users and doesn't feel native.

What if Neovim actually add a function vim.snippet.add later, that has different spec than the one used in your NativeVim?

That can happen! and that's why NativeVim has multiple branches (stable/nightly. I should rename them to target specific versions.) Breaking change can also happen for other APIs forcing users to change their config, so I think it is fine to have one more API with potential breaking change.

It is not ideal solution, I agree with that. But I choose to hack on global vim.snippet module instead of providing NativeVim.snippet module. I can easily see NativeVim grow up to be a standalone Neovim Distro with that direction. I'd rather remove custom snippets feature entirely and wait until Neovim natively supports it.

Hope this makes things clearer.

[brianhuster]

But having a function under vim.snippet module which users can't even look for in :help doc is even more confusing.

That can happen! and that's why NativeVim has multiple branches (stable/nightly. I should rename them to target specific versions.) Breaking change can also happen for other APIs forcing users to change their config, so I think it is fine to have one more API with potential breaking change.

So you are expecting users to install NativeVim as a plugin? And that they have to update this "plugin" after Nvim updates to a new version?

[boltlessengineer]

So you are expecting users to install NativeVim as a plugin?

No, I'm expecting users to read it as a template. Similar to kickstart.nvim.
Users can read the definition and understand that it is defined where. It is just ~200 lines of code.
Maybe we can add some comments to warn users for unofficial APIs.

[brianhuster]

Having multiple modules to deal with snippets might confuse users and doesn't feel native.

Users can read the definition and understand that it is defined where. It is just ~200 lines of code.

If users still have to be aware that vim.snippet.add is not built-in, then what is the point of putting it in vim.snippet module?

Isn't it normal that sometimes you use a library that miss a function, you would write that function in your own module, your own namespace instead of polutting that library?

[boltlessengineer]

If users still have to be aware that vim.snippet.add is not built-in, then what is the point of putting it in vim.snippet module?

Makes sense. I'll remove the vim.snippet.add and wait until Neovim has builtin custom snippet feature.

Thank you for sharing your opinions!