Make append check work isolated, update check type for append (#181)

Author: bombsimon

testdata/src/default_config/assign/assign.go

@@ -29,7 +29,7 @@ func strictAppend() {
 	x := "c"
 	s = append(s, x)
 	y := "e"
-	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above assign\)`
+	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above append\)`
 	s = append(s, y)
 }
 

testdata/src/default_config/assign/assign.go.golden

@@ -30,7 +30,7 @@ func strictAppend() {
 	s = append(s, x)
 	y := "e"
 
-	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above assign\)`
+	s = append(s, "d") // want `missing whitespace above this line \(no shared variables above append\)`
 	s = append(s, y)
 }
 

testdata/src/with_config/append_only/code.go

@@ -0,0 +1,9 @@
+package testpkg
+
+func fn1(s []string) {
+	a := "a"
+	s = append(s, a)
+
+	x := 1
+	s = append(s, "s") // want `missing whitespace above this line \(no shared variables above append\)`
+}

testdata/src/with_config/append_only/code.go.golden

@@ -0,0 +1,11 @@
+package testpkg
+
+func fn1(s []string) {
+	a := "a"
+	s = append(s, a)
+
+	x := 1
+
+	s = append(s, "s") // want `missing whitespace above this line \(no shared variables above append\)`
+}
+

wsl.go

@@ -402,6 +402,8 @@ func (w *WSL) checkAssign(stmt *ast.AssignStmt, cursor *Cursor) {
 		for _, expr := range stmt.Rhs {
 			w.checkExpr(expr, cursor)
 		}
+
+		w.checkAppend(stmt, cursor)
 	}()
 
 	if _, ok := w.config.Checks[CheckAssign]; !ok {
@@ -411,7 +413,6 @@ func (w *WSL) checkAssign(stmt *ast.AssignStmt, cursor *Cursor) {
 	cursor.SetChecker(CheckAssign)
 
 	w.checkCuddlingWithoutIntersection(stmt, cursor)
-	w.checkAppend(stmt, cursor)
 }
 
 func (w *WSL) checkAppend(stmt *ast.AssignStmt, cursor *Cursor) {
@@ -444,7 +445,7 @@ func (w *WSL) checkAppend(stmt *ast.AssignStmt, cursor *Cursor) {
 	}
 
 	if !hasIntersection(appendNode, previousNode) {
-		w.addErrorNoIntersection(stmt.Pos(), cursor.checkType)
+		w.addErrorNoIntersection(stmt.Pos(), CheckAppend)
 	}
 }
 

wsl_test.go

@@ -93,6 +93,13 @@ func TestWithConfig(t *testing.T) {
 				config.Checks.Add(CheckErr)
 			},
 		},
+		{
+			subdir: "append_only",
+			configFn: func(config *Configuration) {
+				config.Checks = NoChecks()
+				config.Checks.Add(CheckAppend)
+			},
+		},
 	} {
 		t.Run(tc.subdir, func(t *testing.T) {
 			config := NewConfig()