Skip to content

Commit 516f268

Browse files
Merge pull request bigcommerce#2557 from bigcommerce/ORDERS-7036
refactor(orders): ORDERS-7036 refactor orders/invoice.html pickup_details section to better align with existing pickup_address output
2 parents 8be678d + 3f62ddf commit 516f268

3 files changed

Lines changed: 13 additions & 10 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## Draft
8+
- Add net-new "order.pickup_addresses" to unify objects used on Order Details and Order Invoice pages [#2557](https://github.com/bigcommerce/cornerstone/pull/2557)
89

910
## 6.16.2 (06-18-2025)
1011
- Restore indentation and quote rules to match BC Sass Style Guide [#2554](https://github.com/bigcommerce/cornerstone/pull/2554)

templates/pages/account/orders/details.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ <h3 class="account-heading">{{lang 'account.orders.details.ship_to'}}</h3>
6464
</ul>
6565
</section>
6666
{{/if}}
67-
{{#if order.pickup_address}}
67+
{{#if order.pickup_addresses}}
6868
<section class="account-sidebar-block">
6969
<h3 class="account-heading">{{lang 'account.orders.details.pickup'}}</h3>
70-
{{#each order.pickup_address}}
70+
{{#each order.pickup_addresses}}
7171
<dl class="definitionList">
7272
<dt class="definitionList-key">{{lang 'account.orders.details.pickup_method'}}</dt>
7373
<dd class="definitionList-value">{{sanitize pickup_method_display_name}}</dd>
@@ -86,7 +86,7 @@ <h3 class="account-heading">{{lang 'account.orders.details.pickup'}}</h3>
8686
<dt class="definitionList-key">{{lang 'account.orders.details.phone'}}</dt>
8787
<dd class="definitionList-value">{{{ sanitize location_phone}}}</dd>
8888
{{/if}}
89-
{{#if order.pickup_address.location_email}}
89+
{{#if location_email}}
9090
<dt class="definitionList-key">{{lang 'account.orders.details.email'}}</dt>
9191
<dd class="definitionList-value">{{{ sanitize location_email}}}</dd>
9292
{{/if}}

templates/pages/account/orders/invoice.html

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,18 +56,20 @@ <h3>{{lang 'account.orders.details.ship_to'}}</h3>
5656
</div>
5757
{{/unless}}
5858
{{/if}}
59-
{{#if order.pickup_address}}
59+
{{#if order.pickup_addresses}}
6060
{{#unless order.has_multiple_shipping_addresses}}
6161
<div class="ShippingAddress">
6262
<h3>{{lang 'account.orders.details.pickup_details'}}</h3>
6363
<ul>
64-
<li><strong>{{order.pickup_address.line1}}</strong></li>
65-
<li>{{order.pickup_address.line2}}</li>
66-
<li>{{order.pickup_address.city}}, {{order.pickup_address.state}} {{order.pickup_address.zip}}</li>
67-
<li>{{order.pickup_address.country}}</li>
64+
{{#each order.pickup_addresses}}
65+
<li><strong>{{location_line_1}}</strong></li>
66+
<li>{{location_line_2}}</li>
67+
<li>{{location_city}}, {{location_state}} {{location_zip}}</li>
68+
<li>{{location_country_name}}</li>
6869
<li>&nbsp;</li>
69-
<li>{{lang 'invoice.phone' number=order.pickup_address.phone}}</li>
70-
{{#if order.pickup_address.email}}<li>{{lang 'invoice.email' email=order.pickup_address.email}}</li>{{/if}}
70+
<li>{{lang 'invoice.phone' number=location_phone}}</li>
71+
{{#if location_email}}<li>{{lang 'invoice.email' email=location_email}}</li>{{/if}}
72+
{{/each}}
7173
</ul>
7274
</div>
7375
{{/unless}}

0 commit comments

Comments
 (0)