feat: make use of prebuilt toolchain for e2e

Make sure all of our e2e use a shared prebuilt bazeldnf binary instead
of each one building their own, this simplifies our MODULE.bazel for
all of our e2e tests considerably as we no longer to keep prebuilt
protoc or golang dependencies

Author: manuelnaranjo

e2e/bazel-bzlmod-lock-file-from-args/.bazelrc

@@ -7,10 +7,6 @@ import %workspace%/../../.aspect/bazelrc/performance.bazelrc
 
 # Specific project flags go here if we have some
 common --enable_bzlmod
-common --extra_toolchains=@bazeldnf//cmd:bazeldnf-host-toolchain
-
-# prebuilt protoc
-common --incompatible_enable_proto_toolchain_resolution
 
 # Load any settings & overrides specific to the current user from `.bazelrc.user`.
 # This file should appear in `.gitignore` so that settings are not shared with team members. This

e2e/bazel-bzlmod-lock-file-from-args/MODULE.bazel

@@ -9,32 +9,6 @@ local_path_override(
 )
 
 bazel_dep(name = "rules_pkg", version = "1.1.0")
-bazel_dep(name = "rules_go", version = "0.59.0", repo_name = "rules_go")
-
-go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
-go_sdk.download(version = "1.24.1")
-
-bazel_dep(name = "gazelle", version = "0.47.0")
-
-go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
-go_deps.from_file(go_mod = "@bazeldnf//:go.mod")
-use_repo(
-    go_deps,
-    "com_github_adrg_xdg",
-    "com_github_bazelbuild_buildtools",
-    "com_github_crillab_gophersat",
-    "com_github_hashicorp_go_retryablehttp",
-    "com_github_jdx_go_netrc",
-    "com_github_klauspost_compress",
-    "com_github_onsi_gomega",
-    "com_github_sassoftware_go_rpmutils",
-    "com_github_sirupsen_logrus",
-    "com_github_spf13_cobra",
-    "com_github_ulikunitz_xz",
-    "io_k8s_sigs_yaml",
-    "org_golang_x_crypto",
-    "org_golang_x_exp",
-)
 
 bazeldnf_toolchain = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf_toolchain")
 bazeldnf_toolchain.register(disable = True)
@@ -63,13 +37,3 @@ use_repo(
     bazeldnf,
     "bazeldnf_rpms",
 )
-
-bazel_dep(name = "toolchains_protoc", version = "0.6.0", dev_dependency = True)
-
-protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc", dev_dependency = True)
-use_repo(protoc, "toolchains_protoc_hub")
-
-register_toolchains(
-    "@toolchains_protoc_hub//:all",
-    dev_dependency = True,
-)

e2e/bazel-bzlmod-lock-file/.bazelrc

@@ -6,7 +6,6 @@ import %workspace%/../../.aspect/bazelrc/debug.bazelrc
 import %workspace%/../../.aspect/bazelrc/performance.bazelrc
 
 common --enable_bzlmod
-common --extra_toolchains=@bazeldnf//cmd:bazeldnf-host-toolchain
 
 # Specific project flags go here if we have some
 

e2e/bazel-bzlmod-lock-file/MODULE.bazel

@@ -9,46 +9,9 @@ local_path_override(
 )
 
 bazel_dep(name = "rules_pkg", version = "1.1.0")
-bazel_dep(name = "rules_go", version = "0.59.0", repo_name = "rules_go")
 
-go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
-go_sdk.download(version = "1.24.1")
-
-bazel_dep(name = "gazelle", version = "0.47.0")
-
-go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
-go_deps.from_file(go_mod = "@bazeldnf//:go.mod")
-use_repo(
-    go_deps,
-    "com_github_adrg_xdg",
-    "com_github_bazelbuild_buildtools",
-    "com_github_crillab_gophersat",
-    "com_github_hashicorp_go_retryablehttp",
-    "com_github_jdx_go_netrc",
-    "com_github_klauspost_compress",
-    "com_github_onsi_gomega",
-    "com_github_sassoftware_go_rpmutils",
-    "com_github_sirupsen_logrus",
-    "com_github_spf13_cobra",
-    "com_github_ulikunitz_xz",
-    "io_k8s_sigs_yaml",
-    "org_golang_x_crypto",
-    "org_golang_x_exp",
-)
-
-bazel_dep(name = "toolchains_protoc", version = "0.6.0")
-
-protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc")
-protoc.toolchain(
-    google_protobuf = "com_google_protobuf",
-    version = "v27.3",
-)
-use_repo(protoc, "com_google_protobuf", "toolchains_protoc_hub")
-
-register_toolchains(
-    "@toolchains_protoc_hub//:all",
-    dev_dependency = True,
-)
+bazeldnf_toolchain = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf_toolchain")
+bazeldnf_toolchain.register(disable = True)
 
 bazeldnf = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf")
 bazeldnf.config(

e2e/bazel-bzlmod-toolchain-from-source-lock-file/.bazelrc

@@ -8,10 +8,6 @@ import %workspace%/../../.aspect/bazelrc/performance.bazelrc
 
 # Specific project flags go here if we have some
 common --enable_bzlmod
-common --extra_toolchains=@bazeldnf//cmd:bazeldnf-host-toolchain
-
-# prebuilt protoc
-common --incompatible_enable_proto_toolchain_resolution
 
 # Load any settings & overrides specific to the current user from `.bazelrc.user`.
 # This file should appear in `.gitignore` so that settings are not shared with team members. This

e2e/bazel-bzlmod-toolchain-from-source-lock-file/MODULE.bazel

@@ -9,7 +9,6 @@ local_path_override(
 )
 
 bazel_dep(name = "rules_pkg", version = "1.1.0")
-bazel_dep(name = "toolchains_protoc", version = "0.6.0")
 
 bazeldnf = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf")
 bazeldnf.toolchain(disable = True)

e2e/bazel-bzlmod-toolchain-from-source/.bazelrc

@@ -7,8 +7,6 @@ import %workspace%/../../.aspect/bazelrc/performance.bazelrc
 
 # Specific project flags go here if we have some
 common --enable_bzlmod
-common --extra_toolchains=@bazeldnf//cmd:bazeldnf-host-toolchain
-common --incompatible_enable_proto_toolchain_resolution
 
 # Load any settings & overrides specific to the current user from `.bazelrc.user`.
 # This file should appear in `.gitignore` so that settings are not shared with team members. This

e2e/bazel-bzlmod-toolchain-from-source/MODULE.bazel

@@ -9,45 +9,6 @@ local_path_override(
 )
 
 bazel_dep(name = "rules_pkg", version = "1.1.0")
-bazel_dep(name = "rules_go", version = "0.59.0", repo_name = "rules_go")
-
-go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
-go_sdk.download(version = "1.24.1")
-
-bazel_dep(name = "gazelle", version = "0.47.0")
-bazel_dep(name = "toolchains_protoc", version = "0.6.0")
-
-protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc")
-protoc.toolchain(
-    google_protobuf = "com_google_protobuf",
-    version = "v27.3",
-)
-use_repo(protoc, "com_google_protobuf", "toolchains_protoc_hub")
-
-register_toolchains(
-    "@toolchains_protoc_hub//:all",
-    dev_dependency = True,
-)
-
-go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
-go_deps.from_file(go_mod = "@bazeldnf//:go.mod")
-use_repo(
-    go_deps,
-    "com_github_adrg_xdg",
-    "com_github_bazelbuild_buildtools",
-    "com_github_crillab_gophersat",
-    "com_github_hashicorp_go_retryablehttp",
-    "com_github_jdx_go_netrc",
-    "com_github_klauspost_compress",
-    "com_github_onsi_gomega",
-    "com_github_sassoftware_go_rpmutils",
-    "com_github_sirupsen_logrus",
-    "com_github_spf13_cobra",
-    "com_github_ulikunitz_xz",
-    "io_k8s_sigs_yaml",
-    "org_golang_x_crypto",
-    "org_golang_x_exp",
-)
 
 bazeldnf_toolchain = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf_toolchain")
 bazeldnf_toolchain.register(disable = True)

e2e/bazel-bzlmod/MODULE.bazel

@@ -8,6 +8,9 @@ local_path_override(
     path = "../..",
 )
 
+bazeldnf_toolchain = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf_toolchain")
+bazeldnf_toolchain.register(disable = True)
+
 bazel_dep(name = "rules_pkg", version = "1.1.0")
 
 bazeldnf = use_extension("@bazeldnf//bazeldnf:extensions.bzl", "bazeldnf")

e2e/bazel-workspace/WORKSPACE

@@ -22,15 +22,10 @@ load("@bazeldnf//bazeldnf:defs.bzl", "rpm")
 load(
     "@bazeldnf//bazeldnf:repositories.bzl",
     "bazeldnf_dependencies",
-    "bazeldnf_register_toolchains",
 )
 
 bazeldnf_dependencies()
 
-bazeldnf_register_toolchains(
-    name = "bazeldnf_prebuilt",
-)
-
 rpm(
     name = "libvirt-devel-11.0.0-1.fc42.x86_64.rpm",
     sha256 = "dba37bbe57903afe49b5666f1781eb50001baa81af4584b355db0b6a2afad9fa",