bazel: use top level dependencies only

When consuming the lock file make sure we only make use of the top level
dependencies ignoring transitive ones.

Author: manuelnaranjo

bazeldnf/extensions.bzl

@@ -211,7 +211,7 @@ def _handle_lock_file(config, module_ctx, registered_rpms = {}):
             dependencies = []
         else:
             dependencies = [x.replace("+", "plus") for x in dependencies]
-            dependencies = ["@{}{}//rpm".format(config.rpm_repository_prefix, x) for x in dependencies]
+            dependencies = ["@{}{}//rpm:rpm-file".format(config.rpm_repository_prefix, x) for x in dependencies]
 
         rpm_name = rpm.pop("name", None)
         if not rpm_name:

internal/rpm.bzl

@@ -24,7 +24,7 @@ RpmInfo = provider(
         other rules like rpmtree
     """,
     fields = {
-        "deps": "depset of other dependencies",
+        "deps": "label of the RPM dependencies",
         "file": "label of the RPM file",
     },
 )
@@ -34,36 +34,38 @@ def _rpm_rule_impl(ctx):
     Implementation for the rpm rule
 
     Allows to pass information about an RPM file to other rules
-    like rpmtree, keeping track of the dependency tree
+    like rpmtree, keeping track of target rpm plus it's entire
+    dependency list
     """
-    deps_list = []
-
-    for dep in ctx.attr.deps:
-        deps_list.append(dep[RpmInfo].deps)
-
     rpm_info = RpmInfo(
         file = ctx.file.file,
-        deps = depset(direct = [ctx.file.file], transitive = deps_list),
+        deps = ctx.files.deps,
     )
 
     return [
         rpm_info,
         DefaultInfo(
-            files = depset(direct = [ctx.file.file], transitive = deps_list),
+            files = depset(direct = [ctx.file.file] + ctx.files.deps),
         ),
     ]
 
 rpm_rule = rule(
     implementation = _rpm_rule_impl,
     attrs = {
         "file": attr.label(allow_single_file = True, mandatory = True),
-        "deps": attr.label_list(providers = [RpmInfo]),
+        "deps": attr.label_list(allow_files = True, mandatory = False),
     },
 )
 
 _HTTP_FILE_BUILD = """
 load("@bazeldnf//internal:rpm.bzl", "rpm_rule")
 package(default_visibility = ["//visibility:public"])
+
+filegroup(
+    name = "rpm-file",
+    srcs = ["{downloaded_file_path}"],
+)
+
 rpm_rule(
     name = "rpm",
     file = "{downloaded_file_path}",
@@ -102,7 +104,6 @@ _rpm_attrs = {
     "integrity": attr.string(),
     "dependencies": attr.label_list(
         mandatory = False,
-        providers = [RpmInfo],
     ),
 }
 
@@ -115,7 +116,7 @@ def _null_rpm_rule_impl(_):
     return [
         RpmInfo(
             file = "",
-            deps = depset(),
+            deps = [],
         ),
         DefaultInfo(files = depset()),
     ]

internal/rpmtree.bzl

@@ -49,7 +49,10 @@ def _rpm2tar_impl(ctx):
     all_rpms = []
 
     for target in ctx.attr.rpms:
-        for rpm in target[RpmInfo].deps.to_list():
+        if target[RpmInfo].file not in all_rpms:
+            all_rpms.append(target[RpmInfo].file)
+
+        for rpm in target[RpmInfo].deps:
             if rpm not in all_rpms:
                 all_rpms.append(rpm)