Extend WebhookConfigurations to any apiVersion (#401)

Titouan BION · web-flow · commit ae30deba12dd · 2021-11-26T10:34:17.000+01:00
We'd rather fail close on validation that an object unvalidated reach the cluster.
diff --git a/cmd/shipperctl/configurator/cluster.go b/cmd/shipperctl/configurator/cluster.go
@@ -432,7 +432,7 @@ func (c *Cluster) CreateOrUpdateValidatingWebhookConfiguration(caBundle []byte,
 						},
 						Rule: admissionregistrationv1beta1.Rule{
 							APIGroups:   []string{shipper.SchemeGroupVersion.Group},
-							APIVersions: []string{shipper.SchemeGroupVersion.Version},
+							APIVersions: []string{"*"},
 							Resources:   []string{"*"},
 						},
 					},
diff --git a/cmd/shipperctl/configurator/cluster_test.go b/cmd/shipperctl/configurator/cluster_test.go
@@ -175,7 +175,7 @@ func (f *fixture) newValidatingWebhookConfiguration(caBundle []byte, namespace s
 						Operations: operations,
 						Rule: admissionregistrationv1beta1.Rule{
 							APIGroups:   []string{shipper.SchemeGroupVersion.Group},
-							APIVersions: []string{shipper.SchemeGroupVersion.Version},
+							APIVersions: []string{"*"},
 							Resources:   []string{"*"},
 						},
 					},
