Skip to content

Commit 1a6e46a

Browse files
authored
feat: JdocSpecReader.streamFiles @MustBeClosed (#135)
* build: errorprone-annotations dependency * feat: JdocSpecReader.streamFiles @MustBeClosed
1 parent 0b229b3 commit 1a6e46a

4 files changed

Lines changed: 10 additions & 2 deletions

File tree

buildSrc/src/main/groovy/java-conventions.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,10 @@ configurations {
8989
dependencies {
9090
internalPlatform platform(project(":jdoc-platform"))
9191

92+
compileOnly "com.google.errorprone:error_prone_annotations"
93+
94+
testCompileOnly "com.google.errorprone:error_prone_annotations"
95+
9296
testImplementation "org.assertj:assertj-core"
9397
testImplementation "org.junit.jupiter:junit-jupiter"
9498
testImplementation "org.junit.platform:junit-platform-suite"

gradle/libs.versions.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ checkstyle = { module = "com.puppycrawl.tools:checkstyle", version.ref = "checks
2020
commons-io = { module = "commons-io:commons-io", version.ref = "commons-io" }
2121
commons-lang3 = { module = "org.apache.commons:commons-lang3", version.ref = "commons-lang3" }
2222
cucumber-bom = { module = "io.cucumber:cucumber-bom", version.ref = "cucumber" }
23+
errorprone-annotations = { module = "com.google.errorprone:error_prone_annotations", version.ref = "errorprone" }
2324
errorprone-core = { module = "com.google.errorprone:error_prone_core", version.ref = "errorprone" }
2425
javaparser-core = { module = "com.github.javaparser:javaparser-core", version.ref = "javaparser" }
2526
jdoc-spock = { module = "io.github.boolivar.jdoctest:jdoc-spock", version.ref = "jdoc-spock" }

jdoc-junit-engine-commons/src/main/java/org/bool/jdoc/core/JdocSpecReader.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.bool.jdoc.core;
22

3+
import com.google.errorprone.annotations.MustBeClosed;
34
import lombok.AllArgsConstructor;
45
import lombok.SneakyThrows;
56
import org.junit.platform.engine.DiscoverySelector;
@@ -45,6 +46,7 @@ public List<SpecSource> readSpecs(List<DiscoverySelector> selectors) {
4546
.collect(Collectors.toList());
4647
}
4748

49+
@MustBeClosed
4850
@SneakyThrows
4951
private Stream<Path> streamFiles(DiscoverySelector selector) {
5052
if (selector instanceof DirectorySelector) {

jdoc-platform/build.gradle.kts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@ dependencies {
1111
api(platform(libs.junit.bom))
1212
constraints {
1313
api(libs.commons.io)
14-
api(libs.javaparser.core)
1514
api(libs.commons.lang3)
16-
api(libs.spock.core)
15+
api(libs.errorprone.annotations)
16+
api(libs.javaparser.core)
1717
api(libs.jspecify)
18+
api(libs.spock.core)
1819

1920
api(libs.assertj.core)
2021
api(libs.mockito.junitJupiter)

0 commit comments

Comments
 (0)