♻️ s3 패키지 리팩토링 (#50)

Author: Yeonu-Kim

app/api/v1/endpoints/s3.py

@@ -2,11 +2,9 @@
 
 from app.api.v1.endpoints.application import router as application_router
 from app.api.v1.endpoints.event import router as event_router
-from app.api.v1.endpoints.s3 import router as s3_router
 from app.api.v1.endpoints.store import router as store_router
 
 router = APIRouter()
 router.include_router(store_router)
 router.include_router(event_router)
 router.include_router(application_router)
-router.include_router(s3_router)

app/api/v1/router.py

@@ -57,6 +57,9 @@ def __init__(self, error: ErrorCode) -> None:
 )
 GEN_005 = ErrorCode(400, "GEN_005", "Invalid wallet address format")
 
+# S3
+S3_001 = ErrorCode(500, "S3_001", "Failed to generate presigned URL")
+
 # Image (server-side only, not in mock)
 IMAGE_001 = ErrorCode(422, "IMAGE_001", "Image does not meet the event conditions")
 IMAGE_002 = ErrorCode(400, "IMAGE_002", "Image not found or inaccessible")

app/core/exceptions.py

@@ -12,6 +12,7 @@
 from app.core.exceptions import AppException
 from app.db.seed import reset_and_seed
 from app.db.session import engine
+from app.s3.router import router as s3_router
 
 
 @asynccontextmanager
@@ -24,6 +25,7 @@ async def lifespan(app: FastAPI) -> AsyncGenerator[None, None]:
 app = FastAPI(title=settings.app_name, debug=settings.debug, lifespan=lifespan)
 
 app.include_router(auth_router, prefix="/api")
+app.include_router(s3_router, prefix="/api")
 app.include_router(api_router, prefix="/api")
 
 

app/main.py

@@ -0,0 +1,6 @@
+from app.s3.service import S3Service
+from app.s3.service_impl import S3ServiceImpl
+
+
+def get_s3_service() -> S3Service:
+    return S3ServiceImpl()

app/s3/__init__.py

@@ -0,0 +1,19 @@
+from fastapi import APIRouter, Depends
+
+from app.s3.dependencies import get_s3_service
+from app.s3.schemas import S3PresignedUploadReq, S3PresignedUploadResp
+from app.s3.service import S3Service
+from app.schemas.common import SuccessResponse
+
+router = APIRouter(prefix="/s3", tags=["S3"])
+
+
+@router.post("", response_model=SuccessResponse[S3PresignedUploadResp])
+def create_presigned_upload_url(
+    body: S3PresignedUploadReq,
+    service: S3Service = Depends(get_s3_service),
+) -> SuccessResponse[S3PresignedUploadResp]:
+    result = service.generate_presigned_upload_url(
+        body.fileName, body.fileType, body.contentType
+    )
+    return SuccessResponse(data=result)

app/s3/dependencies.py

@@ -0,0 +1,11 @@
+from abc import ABC, abstractmethod
+
+from app.s3.schemas import S3PresignedUploadResp
+from app.schemas.common import S3FileType
+
+
+class S3Service(ABC):
+    @abstractmethod
+    def generate_presigned_upload_url(
+        self, file_name: str, file_type: S3FileType, content_type: str
+    ) -> S3PresignedUploadResp: ...

app/s3/router.py

@@ -0,0 +1,40 @@
+import uuid
+
+import boto3  # type: ignore[import-untyped]
+from botocore.exceptions import ClientError  # type: ignore[import-untyped]
+
+from app.core.config import settings
+from app.core.exceptions import S3_001, AppException
+from app.s3.schemas import S3PresignedUploadResp
+from app.s3.service import S3Service
+from app.schemas.common import S3FileType
+
+
+class S3ServiceImpl(S3Service):
+    def generate_presigned_upload_url(
+        self, file_name: str, file_type: S3FileType, content_type: str
+    ) -> S3PresignedUploadResp:
+        bucket = (
+            settings.s3_public_bucket
+            if file_type == S3FileType.STORE
+            else settings.s3_private_bucket
+        )
+        s3_key = f"{file_type.value.lower()}/{uuid.uuid4()}/{file_name}"
+
+        client = boto3.client(
+            "s3",
+            aws_access_key_id=settings.aws_access_key_id,
+            aws_secret_access_key=settings.aws_secret_access_key,
+            region_name=settings.aws_region,
+            endpoint_url=f"https://s3.{settings.aws_region}.amazonaws.com",
+        )
+        try:
+            url: str = client.generate_presigned_url(
+                "put_object",
+                Params={"Bucket": bucket, "Key": s3_key, "ContentType": content_type},
+                ExpiresIn=settings.s3_presigned_expiry,
+            )
+        except ClientError as e:
+            raise AppException(S3_001) from e
+
+        return S3PresignedUploadResp(url=url, s3Key=s3_key)