Add check for numeric_limits

mborland · mborland · commit a3d11499c7c2 · 2025-06-25T11:05:14.000-04:00
diff --git a/include/boost/charconv/detail/to_chars_integer_impl.hpp b/include/boost/charconv/detail/to_chars_integer_impl.hpp
@@ -232,8 +232,11 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_128integer_impl(char* first, c
     }
 
     // Strip the sign from the value and apply at the end after parsing if the type is signed
-    #ifdef BOOST_CHARCONV_HAS_INT128
-    BOOST_IF_CONSTEXPR (std::is_same<boost::int128_type, Integer>::value)
+    BOOST_IF_CONSTEXPR (std::numeric_limits<Integer>::is_signed
+                        #ifdef BOOST_CHARCONV_HAS_INT128
+                        || std::is_same<boost::int128_type, Integer>::value
+                        #endif
+                        )
     {
         if (value < 0)
         {
@@ -246,7 +249,6 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_128integer_impl(char* first, c
         }
     }
     else
-    #endif
     {
         unsigned_value = static_cast<Unsigned_Integer>(value);
     }

Original file line number	Diff line number	Diff line change
`@@ -232,8 +232,11 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_128integer_impl(char* first, c`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`// Strip the sign from the value and apply at the end after parsing if the type is signed`
`235`		`- #ifdef BOOST_CHARCONV_HAS_INT128`
`236`		`- BOOST_IF_CONSTEXPR (std::is_same<boost::int128_type, Integer>::value)`
	`235`	`+ BOOST_IF_CONSTEXPR (std::numeric_limits<Integer>::is_signed`
	`236`	`+ #ifdef BOOST_CHARCONV_HAS_INT128`
	`237`	`+ \|\| std::is_same<boost::int128_type, Integer>::value`
	`238`	`+ #endif`
	`239`	`+ )`
`237`	`240`	`{`
`238`	`241`	`if (value < 0)`
`239`	`242`	`{`
`@@ -246,7 +249,6 @@ BOOST_CHARCONV_CONSTEXPR to_chars_result to_chars_128integer_impl(char* first, c`
`246`	`249`	`}`
`247`	`250`	`}`
`248`	`251`	`else`
`249`		`- #endif`
`250`	`252`	`{`
`251`	`253`	`unsigned_value = static_cast<Unsigned_Integer>(value);`
`252`	`254`	`}`