Skip to content

Commit 496e88b

Browse files
committed
remove CMAKE_BUILD_TYPE from Windows CI configuration
For Visual Studio, cmake generates just one vcxproj for all configurations. The presence of CMAKE_BUILD_TYPE on the command line leads to a warning.
1 parent c54307b commit 496e88b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/windows.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ jobs:
2424
- uses: actions/checkout@v4
2525

2626
- name: Configure CMake
27-
# Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
27+
# Configure CMake in a 'build' subdirectory. Visual Studio is a multi-config generator, so we don't use CMAKE_BUILD_TYPE.
2828
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
29-
run: cmake -B build -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DCXX_STD=${{ matrix.cxx_std }}
29+
run: cmake -B build -DCXX_STD=${{ matrix.cxx_std }}
3030

3131
- name: Build
3232
working-directory: build
33-
run: cmake --build . -- /p:CL_MPcount=4
33+
run: cmake --build . --config ${{ env.BUILD_TYPE }} -- /p:CL_MPcount=4
3434

3535
- name: Test
3636
working-directory: build/test

0 commit comments

Comments
 (0)