From 0ca888f8afc5233c9e48878e4630f1a3b33657e6 Mon Sep 17 00:00:00 2001 From: John Eckersberg Date: Thu, 20 Feb 2025 14:34:43 -0500 Subject: [PATCH] kargs: do not set ARCH envvar in tests std::env::set_var is unsafe in 2024 edition, and upon looking into that this use in the kargs test came up. We don't need to set the environment variable here, in fact I don't think this ever worked in the first place. Signed-off-by: John Eckersberg --- lib/src/kargs.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/kargs.rs b/lib/src/kargs.rs index 5df1497c1..790ba919b 100644 --- a/lib/src/kargs.rs +++ b/lib/src/kargs.rs @@ -229,7 +229,7 @@ match-architectures = ["x86_64", "aarch64"] .to_string(); let parsed_kargs = parse_kargs_toml(&file_content, sys_arch).unwrap(); assert_eq!(parsed_kargs, ["console=tty0", "nosmt"]); - std::env::set_var("ARCH", "aarch64"); + let sys_arch = "aarch64"; let parsed_kargs = parse_kargs_toml(&file_content, sys_arch).unwrap(); assert_eq!(parsed_kargs, ["console=tty0", "nosmt"]); }