Header encryption of 7z

[WirelessAlien]

I am using it on Android. The header is not encrypted when archiving 7z with password and setHeaderEncryption(true)

RandomAccessFile(sevenZFile, "rw").use { raf ->
            val outArchive = SevenZip.openOutArchive7z()

            outArchive.setLevel(compressionLevel)
            outArchive.setSolid(solid)
            outArchive.setSolidSize(8192)
            outArchive.setThreadCount(threadCount)
            outArchive.setHeaderEncryption(true)
            

            outArchive.createArchive(
                RandomAccessFileOutStream(raf), filesToArchive.size,
                object : IOutCreateCallback<IOutItem7z>, ICryptoGetTextPassword {
                    override fun cryptoGetTextPassword(): String? {
                        return password
                    }

                    override fun setOperationResult(operationResultOk: Boolean) {

                    }

                    override fun setTotal(total: Long) {

                    }

                    override fun setCompleted(complete: Long) {
                       
                    }

                    override fun getItemInformation(index: Int, outItemFactory: OutItemFactory<IOutItem7z>): IOutItem7z {
                        val item = outItemFactory.createOutItem()
                        val file = File(filesToArchive[index])
                        val relativePath = file.absolutePath.removePrefix(baseDirectory).removePrefix("/")

                        item.dataSize = file.length()
                        item.propertyPath = relativePath
                        item.propertyIsDir = file.isDirectory
                        item.propertyLastModificationTime = Date(file.lastModified())

                        return item
                    }

                    override fun getStream(i: Int): ISequentialInStream {

                        return RandomAccessFileInStream(RandomAccessFile(filesToArchive[i], "r"))
                    }
                })

            outArchive.close()
        }
    }

[porum]

Hi, I also facing the same problem.

I have roughly reviewed the code of this project. Whenever a setXXX method is called, it invokes the nativeSetXXX function in JavaToCPPOutArchiveImpl.cpp, and ultimately calls the SetProperties function in 7zHandlerOut.cpp of the p7zip project. Within SetProperties, the InitProps function is called first. In InitProps, both _encryptHeadersSpecified and _encryptHeaders are set to false. As a result, even if you call setHeaderEncryption(true), subsequent calls to other setXXX methods will reset the _encryptHeadersSpecified and _encryptHeaders variables to false, meaning header encryption will never take effect.

The simplest fix is to comment out those two lines of code in InitProps function.

sevenzipjbinding/p7zip/CPP/7zip/Archive/7z/7zHandlerOut.cpp

Lines 701 to 702 in d13df34

	_encryptHeadersSpecified = false;
	_encryptHeaders = false;

However, I believe this may be an issue with the JAVA and JNI layer encapsulation. Instead of calling SetProperties every time a setXXX method is invoked, SetProperties should only be called once at the final stage.

[porum]

setLevel also have the same problem, always 5.