Merge pull request #1623 from Zinoberous/master

Fixex GetPropertyUnambiguous and default value comparison for issue 1622
borisdj · Nov 28, 2024 · e7053e1 · e7053e1
2 parents fb12d0e + 5af41f2
commit e7053e1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/EFCore.BulkExtensions.Core/TableInfo.cs b/EFCore.BulkExtensions.Core/TableInfo.cs
@@ -706,7 +706,7 @@ void AddOwnedType(INavigation navigationProperty, string prefix = "")
 
         while (type != null)
         {
-            var property = type.GetProperty(name, BindingFlags.DeclaredOnly);
+            var property = type.GetProperty(name, BindingFlags.DeclaredOnly | BindingFlags.Public | BindingFlags.Instance);
 
             if (property != null)
             {

diff --git a/EFCore.BulkExtensions.Core/Util/GenericsHelpers.cs b/EFCore.BulkExtensions.Core/Util/GenericsHelpers.cs
@@ -36,7 +36,7 @@ internal static IEnumerable<string> GetPropertiesDefaultValue<T>(this T value, T
             if (!type.IsInterface && hasParameterlessConstructor)
                 defaultValue = field.GetValue(Activator.CreateInstance(type, true));
 
-            if (temp == defaultValue ||
+            if (temp?.ToString() == defaultValue?.ToString() ||
                 (temp != null && defaultValue != null &&
                  temp.ToString() == "0" && defaultValue.ToString() == "0") || // situation for int/long prop with HasSequence (test DefaultValues: Document)
                 (temp is Guid guid && guid == Guid.Empty))