fix acclimation

Author: oldrev

client/lib/devices/borneo/lyfi/view_models/acclimation_view_model.dart

@@ -25,6 +25,7 @@ class AcclimationViewModel extends BaseLyfiDeviceViewModel {
 
   Future<void> setEanbled(bool value) async {
     _enabled = value;
+    setChanged();
     notifyListeners();
   }
 
@@ -69,12 +70,8 @@ class AcclimationViewModel extends BaseLyfiDeviceViewModel {
   }
 
   bool validate() {
-    final localNow = DateTime.now();
-    final now = DateTime(localNow.year, localNow.month, localNow.day).toUtc();
     return _startTimestamp.isUtc &&
-        _startTimestamp.year >= now.year &&
-        _startTimestamp.month >= now.month &&
-        _startTimestamp.day >= now.day &&
+        _startTimestamp.isAfter(DateTime(2025, 1, 1).toUtc()) &&
         _days >= 5 &&
         _days <= 100 &&
         _startPercent >= 10 &&

client/packages/borneo_kernel/lib/drivers/borneo/borneo_device_api.dart

@@ -166,7 +166,8 @@ class GeneralBorneoDeviceStatus {
     final dynamic map = cborMap.toObject();
     return GeneralBorneoDeviceStatus(
       power: map['power'],
-      timestamp: DateTime.fromMillisecondsSinceEpoch(map['timestamp'] * 1000),
+      timestamp: DateTime.fromMillisecondsSinceEpoch(map['timestamp'] * 1000,
+          isUtc: true),
       bootDuration: Duration(milliseconds: map['bootDuration']),
       timezone: map['timezone'] ?? '',
       wifiStatus: map['wifiStatus'],
@@ -175,7 +176,8 @@ class GeneralBorneoDeviceStatus {
       error: map['error'],
       shutdownReason: map['shutdownReason'],
       shutdownTimestamp: map['shutdownTimestamp'] > 0
-          ? DateTime.fromMillisecondsSinceEpoch(map['shutdownTimestamp'] * 1000)
+          ? DateTime.fromMillisecondsSinceEpoch(map['shutdownTimestamp'] * 1000,
+              isUtc: true)
           : null,
       temperature: map['temperature'],
       powerVoltage:

client/packages/borneo_kernel/lib/drivers/borneo/lyfi/lyfi_driver.dart

@@ -167,8 +167,9 @@ class AcclimationSettings {
   factory AcclimationSettings.fromMap(dynamic map) {
     return AcclimationSettings(
       enabled: map["enabled"],
-      startTimestamp:
-          DateTime.fromMillisecondsSinceEpoch(map['startTimestamp'] * 1000),
+      startTimestamp: DateTime.fromMillisecondsSinceEpoch(
+          map['startTimestamp'] * 1000,
+          isUtc: true),
       days: map["days"],
       startPercent: map["startPercent"],
     );

client/packages/borneo_kernel/lib/kernel.dart

@@ -235,6 +235,19 @@ final class DefaultKernel implements IKernel {
     });
   }
 
+  Future<bool> _tryDoHeartBeat(BoundDevice bd) async {
+    try {
+      await bd.driver
+          .heartbeat(bd.device, cancelToken: _heartbeatPollingTaskCancelToken)
+          .timeout(kHeartbeatPollingInterval)
+          .asCancellable(_heartbeatPollingTaskCancelToken);
+      return true;
+    } catch (e, stackTrace) {
+      _logger.t("Failed to do heartbeat", error: e, stackTrace: stackTrace);
+      return false;
+    }
+  }
+
   Future<void> _heartbeatPollingPeriodicTask() async {
     if (!isInitialized) {
       return;
@@ -246,11 +259,7 @@ final class DefaultKernel implements IKernel {
       final devices = <BoundDevice>[];
       for (final bd in _boundDevices.values) {
         if (_pollIDList.contains(bd.device.id)) {
-          futures.add(bd.driver
-              .heartbeat(bd.device,
-                  cancelToken: _heartbeatPollingTaskCancelToken)
-              .timeout(kHeartbeatPollingInterval)
-              .asCancellable(_heartbeatPollingTaskCancelToken));
+          futures.add(_tryDoHeartBeat(bd));
           devices.add(bd);
         }
       }

fw/lyfi/main/src/coap-resources/acclimation.c

@@ -97,7 +97,7 @@ static void coap_hnd_acclimation_post(coap_resource_t* resource, coap_session_t*
         return;
     }
 
-    if (start_percent < 0 || start_percent > 100) {
+    if (start_percent < 10 || start_percent > 90) {
         coap_pdu_set_code(response, BO_COAP_CODE_400_BAD_REQUEST);
         return;
     }

fw/lyfi/main/src/led/acclimation.c

@@ -41,20 +41,33 @@ int led_acclimation_drive(time_t utc_now, led_color_t color)
         return 0;
     }
 
+    if (!led_acclimation_is_enabled()) {
+        return 0;
+    }
+
     struct led_acclimation_settings* acc = &_led.settings.acclimation;
     time_t end_time_utc = acc->start_utc + (SECS_PER_DAY * acc->duration);
-    if (utc_now <= end_time_utc) {
+
+    if (utc_now >= acc->start_utc && utc_now <= end_time_utc) {
         if (!_led.acclimation_activated) {
             _led.acclimation_activated = true;
         }
-        int days_elapsed = (int)((end_time_utc - utc_now) / SECS_PER_DAY);
+
+        int days_elapsed = (int)((utc_now - acc->start_utc) / SECS_PER_DAY);
+
+        if (days_elapsed > acc->duration) {
+            days_elapsed = acc->duration;
+        }
+
         int total_increment = 100 - acc->start_percent;
-        int current_increment = days_elapsed * total_increment;
-        int percent = acc->start_percent + (current_increment + acc->duration / 2) / acc->duration;
+        int percent = acc->start_percent + (days_elapsed * total_increment) / acc->duration;
+
+        if (percent > 100) {
+            percent = 100;
+        }
+
         for (size_t ch = 0; ch < LYFI_LED_CHANNEL_COUNT; ch++) {
-            if (end_time_utc <= utc_now) {
-                return (led_brightness_t)(((uint32_t)color[ch] * percent + 50) / 100);
-            }
+            color[ch] = (led_brightness_t)(((uint32_t)color[ch] * percent + 50) / 100);
         }
         return 0;
     }