Skip to content

Commit 972c58c

Browse files
sky1122arnaldo2792
authored andcommitted
nvidia-k8s-device-plugin: adjust device-list-strategy for new type
The 'default' handlebars helper doesn't work with arrays. Adjust how the device-list-strategy property is set depending on the type used in the API settings. Default to 'volume-mounts' when the setting is missing. Signed-off-by: Jingwei Wang <[email protected]> Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
1 parent ece33ef commit 972c58c

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

packages/nvidia-k8s-device-plugin/nvidia-k8s-device-plugin-conf

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[required-extensions]
22
kubelet-device-plugins = "v1"
3-
std = { version = "v1", helpers = ["default"] }
3+
std = { version = "v1", helpers = ["default", "join_array", "is_array"] }
44

55
+++
66
version: v1
@@ -18,7 +18,15 @@ flags:
1818
nvidiaDriverRoot: "/"
1919
plugin:
2020
passDeviceSpecs: {{default true settings.kubelet-device-plugins.nvidia.pass-device-specs}}
21-
deviceListStrategy: {{default "volume-mounts" settings.kubelet-device-plugins.nvidia.device-list-strategy}}
21+
{{#if settings.kubelet-device-plugins.nvidia.device-list-strategy}}
22+
{{#if (is_array settings.kubelet-device-plugins.nvidia.device-list-strategy)}}
23+
deviceListStrategy: [{{join_array "," settings.kubelet-device-plugins.nvidia.device-list-strategy }}]
24+
{{else}}
25+
deviceListStrategy: {{settings.kubelet-device-plugins.nvidia.device-list-strategy}}
26+
{{/if}}
27+
{{else}}
28+
deviceListStrategy: "volume-mounts"
29+
{{/if}}
2230
deviceIDStrategy: {{default "index" settings.kubelet-device-plugins.nvidia.device-id-strategy}}
2331
containerDriverRoot: "/"
2432
{{#if settings.kubelet-device-plugins.nvidia.device-sharing-strategy}}

0 commit comments

Comments
 (0)