details-preferences: Split toggle feature callback

This is important to have because complex toggles require slightly
different parameters.

Fixes #3720

Author: TheEvilSkeleton

Diff for: bottles/frontend/details_preferences_page.py

@@ -226,25 +226,29 @@ def __init__(self, details, config, **kwargs):
         )
         self.btn_cwd.connect("clicked", self.choose_cwd)
         self.btn_cwd_reset.connect("clicked", self.reset_cwd, True)
-        self.switch_mangohud.connect("state-set", self.__toggle_feature, "mangohud")
-        self.switch_obsvkc.connect("state-set", self.__toggle_feature, "obsvkc")
-        self.switch_vkbasalt.connect("state-set", self.__toggle_feature, "vkbasalt")
-        self.switch_fsr.connect("state-set", self.__toggle_feature, "fsr")
+        self.switch_mangohud.connect("state-set", self.__toggle_feature_cb, "mangohud")
+        self.switch_obsvkc.connect("state-set", self.__toggle_feature_cb, "obsvkc")
+        self.switch_vkbasalt.connect("state-set", self.__toggle_feature_cb, "vkbasalt")
+        self.switch_fsr.connect("state-set", self.__toggle_feature_cb, "fsr")
         self.switch_nvapi.connect("state-set", self.__toggle_nvapi)
-        self.switch_gamemode.connect("state-set", self.__toggle_feature, "gamemode")
-        self.switch_gamescope.connect("state-set", self.__toggle_feature, "gamescope")
-        self.switch_sandbox.connect("state-set", self.__toggle_feature, "sandbox")
-        self.switch_discrete.connect("state-set", self.__toggle_feature, "discrete_gpu")
+        self.switch_gamemode.connect("state-set", self.__toggle_feature_cb, "gamemode")
+        self.switch_gamescope.connect(
+            "state-set", self.__toggle_feature_cb, "gamescope"
+        )
+        self.switch_sandbox.connect("state-set", self.__toggle_feature_cb, "sandbox")
+        self.switch_discrete.connect(
+            "state-set", self.__toggle_feature_cb, "discrete_gpu"
+        )
         self.switch_versioning_compression.connect(
             "state-set", self.__toggle_versioning_compression
         )
         self.switch_auto_versioning.connect(
-            "state-set", self.__toggle_feature, "versioning_automatic"
+            "state-set", self.__toggle_feature_cb, "versioning_automatic"
         )
         self.switch_versioning_patterns.connect(
-            "state-set", self.__toggle_feature, "versioning_exclusion_patterns"
+            "state-set", self.__toggle_feature_cb, "versioning_exclusion_patterns"
         )
-        self.switch_vmtouch.connect("state-set", self.__toggle_feature, "vmtouch")
+        self.switch_vmtouch.connect("state-set", self.__toggle_feature_cb, "vmtouch")
         self.combo_runner.connect("notify::selected", self.__set_runner)
         self.combo_dxvk.connect("notify::selected", self.__set_dxvk)
         self.combo_vkd3d.connect("notify::selected", self.__set_vkd3d)
@@ -265,7 +269,7 @@ def __init__(self, details, config, **kwargs):
         if RuntimeManager.get_runtimes("steam"):
             self.row_steam_runtime.set_visible(True)
             self.switch_steam_runtime.connect(
-                "state-set", self.__toggle_feature, "use_steam_runtime"
+                "state-set", self.__toggle_feature_cb, "use_steam_runtime"
             )
 
         """Toggle some utilities according to its availability"""
@@ -406,22 +410,22 @@ def set_config(self, config: BottleConfig):
         parameters = self.config.Parameters
 
         # temporary lock functions connected to the widgets
-        self.switch_mangohud.handler_block_by_func(self.__toggle_feature)
+        self.switch_mangohud.handler_block_by_func(self.__toggle_feature_cb)
         self.switch_nvapi.handler_block_by_func(self.__toggle_nvapi)
-        self.switch_vkbasalt.handler_block_by_func(self.__toggle_feature)
-        self.switch_fsr.handler_block_by_func(self.__toggle_feature)
-        self.switch_obsvkc.handler_block_by_func(self.__toggle_feature)
-        self.switch_gamemode.handler_block_by_func(self.__toggle_feature)
-        self.switch_gamescope.handler_block_by_func(self.__toggle_feature)
-        self.switch_sandbox.handler_block_by_func(self.__toggle_feature)
-        self.switch_discrete.handler_block_by_func(self.__toggle_feature)
+        self.switch_vkbasalt.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_fsr.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_obsvkc.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_gamemode.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_gamescope.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_sandbox.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_discrete.handler_block_by_func(self.__toggle_feature_cb)
         self.switch_versioning_compression.handler_block_by_func(
             self.__toggle_versioning_compression
         )
-        self.switch_auto_versioning.handler_block_by_func(self.__toggle_feature)
-        self.switch_versioning_patterns.handler_block_by_func(self.__toggle_feature)
+        self.switch_auto_versioning.handler_block_by_func(self.__toggle_feature_cb)
+        self.switch_versioning_patterns.handler_block_by_func(self.__toggle_feature_cb)
         with contextlib.suppress(TypeError):
-            self.switch_steam_runtime.handler_block_by_func(self.__toggle_feature)
+            self.switch_steam_runtime.handler_block_by_func(self.__toggle_feature_cb)
         self.combo_runner.handler_block_by_func(self.__set_runner)
         self.combo_dxvk.handler_block_by_func(self.__set_dxvk)
         self.combo_vkd3d.handler_block_by_func(self.__set_vkd3d)
@@ -540,22 +544,24 @@ def set_config(self, config: BottleConfig):
                 self.combo_sync.set_selected(sync_types.index(sync))
 
         # unlock functions connected to the widgets
-        self.switch_mangohud.handler_unblock_by_func(self.__toggle_feature)
+        self.switch_mangohud.handler_unblock_by_func(self.__toggle_feature_cb)
         self.switch_nvapi.handler_unblock_by_func(self.__toggle_nvapi)
-        self.switch_vkbasalt.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_fsr.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_obsvkc.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_gamemode.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_gamescope.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_sandbox.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_discrete.handler_unblock_by_func(self.__toggle_feature)
+        self.switch_vkbasalt.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_fsr.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_obsvkc.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_gamemode.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_gamescope.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_sandbox.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_discrete.handler_unblock_by_func(self.__toggle_feature_cb)
         self.switch_versioning_compression.handler_unblock_by_func(
             self.__toggle_versioning_compression
         )
-        self.switch_auto_versioning.handler_unblock_by_func(self.__toggle_feature)
-        self.switch_versioning_patterns.handler_unblock_by_func(self.__toggle_feature)
+        self.switch_auto_versioning.handler_unblock_by_func(self.__toggle_feature_cb)
+        self.switch_versioning_patterns.handler_unblock_by_func(
+            self.__toggle_feature_cb
+        )
         with contextlib.suppress(TypeError):
-            self.switch_steam_runtime.handler_unblock_by_func(self.__toggle_feature)
+            self.switch_steam_runtime.handler_unblock_by_func(self.__toggle_feature_cb)
         self.combo_runner.handler_unblock_by_func(self.__set_runner)
         self.combo_dxvk.handler_unblock_by_func(self.__set_dxvk)
         self.combo_vkd3d.handler_unblock_by_func(self.__set_vkd3d)
@@ -582,12 +588,15 @@ def __show_feature_dialog(self, _widget: Gtk.Widget, dialog: Adw.Window) -> None
         window = dialog(window=self.window, config=self.config)
         window.present()
 
-    def __toggle_feature(self, _widget: Gtk.Widget, state: bool, key: str) -> None:
+    def __toggle_feature(self, state: bool, key: str) -> None:
         """Toggle a specific feature."""
         self.config = self.manager.update_config(
             config=self.config, key=key, value=state, scope="Parameters"
         ).data["config"]
 
+    def __toggle_feature_cb(self, _widget: Gtk.Widget, state: bool, key: str) -> None:
+        self.__toggle_feature(state=state, key=key)
+
     def __set_sync_type(self, *_args):
         """
         Set the sync type (wine, esync, fsync)
@@ -622,7 +631,7 @@ def __toggle_nvapi(self, widget=False, state=False):
             remove=not state,
         )
 
-        self.__toggle_feature(widget=None, state=state, key="dxvk_nvapi")
+        self.__toggle_feature(state=state, key="dxvk_nvapi")
 
     def __toggle_versioning_compression(self, widget, state):
         """Toggle the versioning compression for current bottle"""
@@ -686,11 +695,11 @@ def update(result: Result[dict], error=False):
                     self.config = result.data["config"]
                 if self.config.Parameters.use_steam_runtime:
                     self.switch_steam_runtime.handler_block_by_func(
-                        self.__toggle_feature
+                        self.__toggle_feature_cb
                     )
                     self.switch_steam_runtime.set_active(True)
                     self.switch_steam_runtime.handler_unblock_by_func(
-                        self.__toggle_feature
+                        self.__toggle_feature_cb
                     )
 
             set_widgets_status(True)