Missing pack/unpack methods

[MDr164]

This library is currently only intended as a client so I can see why request types only have a Pack() method and responses only got an Unpack() method. I intend to use this library for an IPMI server instead so I'd need both methods on such types. Would you accept a PR that adds the missing methods or is that something you'd rather not have in this library directly?

[bougou]

The idea of using this library as server is very appealing, I am very willing to accept the PR that implement these things.

And I think It is not so urgent to implement the actual working code for Unpack()/Pack() for all those existing Request/Response types. They can be supplemented one by one. :)

[MDr164]

Cool, I'll implement those methods then and open some PRs. I envision that I'll have to do minor refactoring by separating some client functions into their own files for readability but so far I got quite far by implementing the missing functions locally. I did however notice that some that some structs could be packed differently so simplify some Pack/Unpack methods.

[MDr164]

Btw I picked this issue back up after some time and I'm currently experimenting with it here: https://github.com/MDr164/go-ipmi/tree/ipmi-server but it turned out I had to restructure quite a bit to make it work cleanly. I was also thinking about creating an API compatible change but that would have required a lot of compromises on the server-side code. I'm running some more tests here in the next couple days before opening any PR, especially around API compatibility with the current library.

[bougou]

Refactoring the root directory into sub-packages is a solid move, especially to accommodate the upcoming server-side code. It improves readability and maintainability.

To avoid disrupting existing users, I suggest we maintain API compatibility by leaving re-export files in the root, such as exports_client.go and exports_types.go. These files can act as a bridge, forwarding calls to the new sub-packages. This ensures the internal structure is cleaner while the public interface remains unchanged.

package main

import (
	_client "github.com/bougou/go-ipmi/pkg/client"
)

var (
	CommandNone        = _client.CommandNone
	CommandGetDeviceID = _client.CommandGetDeviceID
	FormatUsers        = _client.FormatUsers
	NewClient          = _client.NewClient
	NewOpenClient      = _client.NewOpenClient
	NewToolClient      = _client.NewToolClient
	ParseSEL           = _client.ParseSEL
	RenderTable        = _client.RenderTable
	// ... more exports for variables and functions ...
)

const (
	DefaultLanplusRetries    = _client.DefaultLanplusRetries
	DefaultLanplusTimeoutSec = _client.DefaultLanplusTimeoutSec
	DefaultLanRetries        = _client.DefaultLanRetries
	DefaultLanTimeoutSec     = _client.DefaultLanTimeoutSec
	InterfaceLan             = _client.InterfaceLan
	InterfaceLanplus         = _client.InterfaceLanplus
	InterfaceOpen            = _client.InterfaceOpen
	InterfaceTool            = _client.InterfaceTool
	// ... more exports for consts ...
)

type (
	ClearSELRequest      = _client.ClearSELRequest
	ClearSELResponse     = _client.ClearSELResponse
	Client               = _client.Client
	CloseSessionRequest  = _client.CloseSessionRequest
	CloseSessionResponse = _client.CloseSessionResponse
	ColdResetRequest     = _client.ColdResetRequest
	ColdResetResponse    = _client.ColdResetResponse
	Command              = _client.Command
	// ... more exports for types ...
)