Don't do model updates while typing inside double/integer spinboxes, only when finished

Author: stfnp

gui/source/pre/views/primitive/DoubleView.cpp

@@ -9,5 +9,5 @@ DoubleView::DoubleView(QAbstractItemModel* model, QPersistentModelIndex index, c
 
     // Set value from model and keep model up to date on changes
     setValue(model->data(index, Qt::DisplayRole).toDouble());
-    QObject::connect(this, &DoubleSpinBox::valueChanged, this, [=](double value){ model->setData(index, value); });
+    QObject::connect(this, &DoubleSpinBox::contentModified, this, [=, this]{ model->setData(index, this->value()); });
 }

gui/source/pre/views/primitive/IntegerView.cpp

@@ -11,5 +11,5 @@ IntegerView::IntegerView(QAbstractItemModel* model, QPersistentModelIndex index,
 
     // Set value from model and keep model up to date on changes
     setValue(model->data(index, Qt::DisplayRole).toInt());
-    QObject::connect(this, &QSpinBox::valueChanged, this, [=](int value){ model->setData(index, value); });
+    QObject::connect(this, &IntegerSpinBox::contentModified, this, [=, this]{ model->setData(index, this->value()); });
 }

gui/source/pre/widgets/DoubleSpinBox.cpp

@@ -19,7 +19,7 @@ DoubleSpinBox::DoubleSpinBox(const Quantity& quantity, const DoubleRange& range,
     // Prevent catching focus when scrolling, https://stackoverflow.com/a/19382766
     setFocusPolicy(Qt::StrongFocus);
 
-    QObject::connect(lineEdit(), &QLineEdit::textEdited, this, &DoubleSpinBox::contentModified);    // Signal modification by user when the text was edited
+    QObject::connect(lineEdit(), &QLineEdit::editingFinished, this, &DoubleSpinBox::contentModified);    // Signal modification by user when the text was edited
     QObject::connect(&quantity, &Quantity::unitChanged, this, &DoubleSpinBox::updateUnit);
     updateUnit();
 }
@@ -34,7 +34,7 @@ QString DoubleSpinBox::textFromValue(double baseValue) const {
     double unitValue = quantity.getUnit().fromBase(baseValue);
 
     // Convert value to string with fixed-point representation
-    // If the result has a decimal point, remove any trailing zeros and the point as well
+    // If the result has a decimal point, remove any trailing zeros and possibly the point as well
     QString result = QString::number(unitValue, 'f', decimals());
     if(result.indexOf('.') != -1) {
         while(result.endsWith('0')) {

gui/source/pre/widgets/IntegerSpinBox.cpp

@@ -11,6 +11,10 @@ IntegerSpinBox::IntegerSpinBox(const IntegerRange& range, QWidget* parent)
 
     // Prevent catching focus when scrolling, https://stackoverflow.com/a/19382766
     setFocusPolicy(Qt::StrongFocus);
+
+    // Signal modification by user when the text was edited
+    // QSpinBox::valueChanged is not used because it is triggered during typing, leading to unnecessary updates of the model.
+    QObject::connect(this, &QSpinBox::editingFinished, this, &IntegerSpinBox::contentModified);
 }
 
 int IntegerSpinBox::valueFromText(const QString& text) const {
@@ -30,3 +34,8 @@ QValidator::State IntegerSpinBox::validate(QString& text, int& pos) const {
 
     return QValidator::Acceptable;
 }
+
+void IntegerSpinBox::stepBy(int steps) {
+    QSpinBox::stepBy(steps);
+    emit contentModified();    // Signal modification by user when the widget was stepped
+}

gui/source/pre/widgets/IntegerSpinBox.hpp

@@ -4,10 +4,16 @@
 struct IntegerRange;
 
 class IntegerSpinBox: public QSpinBox {
+    Q_OBJECT
+
 public:
     IntegerSpinBox(const IntegerRange& range, QWidget* parent = nullptr);
 
+signals:
+    void contentModified();
+
 private:
     int valueFromText(const QString& text) const override;
     QValidator::State validate(QString &text, int &pos) const override;
+    void stepBy(int steps) override;
 };