Skip to content

Makefile performs destructive system updates (editing dotfiles, installing JRE) #47

Open
@iainmerrick

Description

The Linux installation instructions on the website (https://openapi.bow-swift.io/docs/quick-start/installation-guide/#-linux-users) ask you to sudo make linux. Mac users may be tempted to build from the Makefile as well as the Homebrew installation doesn't currently work (#41).

The linux target breaks normal conventions and does a bunch of destructive updates:

  • It both builds and installs (usually make install is a separate step)
  • It creates system installation directories before building, not after
  • It installs system-wide openjdk-8-jre-headless
  • It installs bash and zsh code completions

Installing dependencies, building the code and installing the code should be separate targets.

It should be possible to both build the code and execute it locally without using sudo.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions