chore: Migrate golangci-lint

Author: bow

.golangci.yml

@@ -1,5 +1,4 @@
-go-version: &go-version "1.24"
-
+version: "2"
 linters:
   enable:
     - bidichk
@@ -12,120 +11,129 @@ linters:
     - goconst
     - gocritic
     - godot
-    - gofmt
-    - goimports
     - gosec
     - nakedret
     - nilerr
     - prealloc
     - revive
-    - stylecheck
+    - staticcheck
     - thelper
     - tparallel
     - unconvert
     - unparam
-    - unused
     - wastedassign
-  disable-all: false
-  exclude-use-default: false
-linters-settings:
-  govet:
-    enable:
-      - assign
-      - copylocks
-      - deepequalerrors
-      - httpresponse
-      - ifaceassert
-      - loopclosure
-      - lostcancel
-      - nilfunc
-      - nilness
-      - stdmethods
-      - unmarshal
-    disable:
-      - printf
-  revive:
-    # See: https://github.com/mgechev/revive#available-rules
-    ignore-generated-header: true
-    severity: warning
+  settings:
+    govet:
+      enable:
+        - assign
+        - copylocks
+        - deepequalerrors
+        - httpresponse
+        - ifaceassert
+        - loopclosure
+        - lostcancel
+        - nilfunc
+        - nilness
+        - stdmethods
+        - unmarshal
+      disable:
+        - printf
+    revive:
+      severity: warning
+      rules:
+        - name: bare-return
+        - name: blank-imports
+        - name: bool-literal-in-expr
+        - name: cognitive-complexity
+          arguments:
+            - 20
+        - name: confusing-naming
+        - name: confusing-results
+        - name: constant-logical-expr
+        - name: cyclomatic
+          arguments:
+            - 20
+        - name: deep-exit
+        - name: defer
+        - name: dot-imports
+        - name: duplicated-imports
+        - name: early-return
+        - name: empty-block
+        - name: error-naming
+        - name: error-return
+        - name: error-strings
+        - name: exported
+        - name: get-return
+        - name: identical-branches
+          severity: error
+        - name: if-return
+        - name: increment-decrement
+        - name: indent-error-flow
+        - name: import-shadowing
+        - name: line-length-limit
+          arguments:
+            - 100
+          severity: error
+        - name: modifies-parameter
+        - name: nested-structs
+        - name: package-comments
+        - name: range
+        - name: range-val-in-closure
+        - name: receiver-naming
+        - name: redefines-builtin-id
+          severity: error
+        - name: struct-tag
+        - name: superfluous-else
+        - name: var-naming
+          arguments:
+            - - ID
+        - name: unconditional-recursion
+        - name: unnecessary-stmt
+        - name: unreachable-code
+        - name: unused-parameter
+        - name: useless-break
+        - name: waitgroup-by-value
+    staticcheck:
+      checks:
+        - all
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
     rules:
-      - name: bare-return
-      - name: blank-imports
-      - name: bool-literal-in-expr
-      - name: cognitive-complexity
-        arguments: [20]
-      - name: confusing-naming
-      - name: confusing-results
-      - name: constant-logical-expr
-      # - name: context-keys-type
-      - name: cyclomatic
-        arguments: [20]
-      - name: deep-exit
-      - name: defer
-      - name: dot-imports
-      - name: duplicated-imports
-      - name: early-return
-      - name: empty-block
-      - name: error-naming
-      - name: error-return
-      - name: error-strings
-      # - name: errorf
-      - name: exported
-      - name: get-return
-      - name: identical-branches
-        severity: error
-      - name: if-return
-      - name: increment-decrement
-      - name: indent-error-flow
-      - name: import-shadowing
-      - name: line-length-limit
-        severity: error
-        arguments: [100]
-      - name: modifies-parameter
-      - name: nested-structs
-      - name: package-comments
-      - name: range
-      - name: range-val-in-closure
-      # - name: range-val-address
-      - name: receiver-naming
-      - name: redefines-builtin-id
-        severity: error
-      # - name: string-of-int
-      - name: struct-tag
-      - name: superfluous-else
-      # - name: time-naming
-      - name: var-naming
-        arguments: [["ID"]]
-      # - name: var-declaration
-      - name: unconditional-recursion
-      - name: unnecessary-stmt
-      - name: unreachable-code
-      - name: unused-parameter
-      - name: useless-break
-      - name: waitgroup-by-value
-  stylecheck:
-    checks: ["all"]
-issues:
-  include:
-    - EXC0002
-    - EXC0003
-  exclude-rules:
-    # ctx can be specified as function param without it being used, by convention
-    - text: "parameter 'ctx' seems to be unused, consider removing"
-      linters: [revive]
-    - path: _test\.go
-      text: "line-length-limit"
+      - linters:
+          - revive
+        text: parameter 'ctx' seems to be unused, consider removing
+      - path: _test\.go
+        text: line-length-limit
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 severity:
-  default-severity: major
+  default: major
   rules:
-    - severity: info
-      linters:
+    - linters:
         - goimports
         - thelper
-    - severity: minor
-      linters:
+      severity: info
+    - linters:
         - dupl
         - goconst
         - tparallel
         - unconvert
         - unparam
+      severity: minor
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

cmd/feed_pull.go

@@ -58,8 +58,8 @@ func newFeedPullCommand() *cobra.Command {
 				errs []error
 				n    int
 				s    = newPullSpinner(rawIDs)
-				max  = uint32(0)
-				ch   = db.PullFeeds(cmd.Context(), ids, nil, &max, perFeedTimeout)
+				maxN = uint32(0)
+				ch   = db.PullFeeds(cmd.Context(), ids, nil, &maxN, perFeedTimeout)
 			)
 
 			s.Start()

internal/reader/backend/rpc.go

@@ -67,9 +67,9 @@ func (r *RPC) PullFeedsF(
 	ids []entity.ID,
 ) func() (<-chan entity.PullResult, error) {
 	return func() (<-chan entity.PullResult, error) {
-		max := uint32(0)
+		maxN := uint32(0)
 		req := api.PullFeedsRequest{
-			MaxEntriesPerFeed: &max,
+			MaxEntriesPerFeed: &maxN,
 			FeedIds:           ids,
 		}
 		stream, err := r.client.PullFeeds(ctx, &req)

internal/reader/ui/popup.go

@@ -35,11 +35,11 @@ func (p *popup) setContent(prim tview.Primitive) {
 }
 
 func (p *popup) setWidth(w int) {
-	p.Grid.SetColumns(0, w, 0)
+	p.SetColumns(0, w, 0)
 }
 
 func (p *popup) setHeight(h int) {
-	p.Grid.SetRows(p.topSpacing, h, p.bottomSpacing)
+	p.SetRows(p.topSpacing, h, p.bottomSpacing)
 }
 
 func newPopup(