BoxDeveloperEditionAPIConnection getAppEnterpriseConnection - Doesn't Allow proxy config

[skumaravelan]

• [X ] I have checked that the [SDK documentation][sdk-docs] doesn't solve my issue.
• [ X] I have checked that the [API documentation][api-docs] doesn't solve my issue.
• [- ] I have searched the [Box Developer Forums][dev-forums] and my issue isn't already reported (or if it has been reported, I have attached a link to it, for reference).
• [ X] I have searched [Issues in this repo][github-repo] and my issue isn't already reported.

Description of the Issue

BoxDeveloperEditionAPIConnection getAppEnterpriseConnection doesn't allow to configure proxy configuration using the methods in this class. Please add support .

Expected behavior to have add another method that would take http proxy as an argument and sent to Http invocation.

[skumaravelan]

Here is the working code that like to be incorporated to support in SDK natively.

    public static BoxDeveloperEditionAPIConnection getAppEnterpriseConnection(
            String enterpriseId,
            String clientId,
            String clientSecret,
            JWTEncryptionPreferences encryptionPref,
            IAccessTokenCache accessTokenCache, Proxy proxy
    ) {

        BoxDeveloperEditionAPIConnection connection = new BoxDeveloperEditionAPIConnection(enterpriseId,
                DeveloperEditionEntityType.ENTERPRISE, clientId, clientSecret, encryptionPref, accessTokenCache);

        if (proxy!=null) {
            connection.setProxy(proxy);
        }
        connection.tryRestoreUsingAccessTokenCache();

        return connection;
    }

[mwwoda]

Thanks for the suggestion. I'll discuss it with the team.

[lukaszsocha2]

Hi @skumaravelan,
we decided not to add this parameter to the method as proxy can be easily added afterwards.
Call:

BoxDeveloperEditionAPIConnection  connection = BoxDeveloperEditionAPIConnection.getAppEnterpriseConnection(...)
connection.setProxy(proxy);

Best,
@lukaszsocha2

[skumaravelan]

Problem is we are using Camel Box Component which has all the helper method, Having this support would help Camel to support natively .

https://github.com/apache/camel/blob/main/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java#L279C86-L280C20

[lukaszsocha2]

Hi,
cannot this code:
if (proxy!=null) { connection.setProxy(proxy); }
be added to camel integration? If we make a required change, camel integration would have to be updated anyway. Or cannot you add this call after calling createAppEnterpriseAuthenticatedConnection method to your code?
Best,
@lukaszsocha2

[skumaravelan]

camel code createAppEnterpriseAuthenticatedConnection method is calling the BoxDeveloperEditionAPIConnection.getAppEnterpriseConnection(configuration.getEnterpriseId(),
configuration.getClientId(), configuration.getClientSecret(), encryptionPref, accessTokenCache);
In turn getAppEnterpriseConnection does not have way to pass Proxy object to these methods as the SDK ignores them. Hence we are completely blocked using them.

public static BoxDeveloperEditionAPIConnection getAppEnterpriseConnection(
    String enterpriseId,
    String clientId,
    String clientSecret,
    JWTEncryptionPreferences encryptionPref,
    IAccessTokenCache accessTokenCache
) {

    BoxDeveloperEditionAPIConnection connection = new BoxDeveloperEditionAPIConnection(enterpriseId,
        DeveloperEditionEntityType.ENTERPRISE, clientId, clientSecret, encryptionPref, accessTokenCache);

    connection.tryRestoreUsingAccessTokenCache();

    return connection;
}

I also checked with Camel owner, he mentioned that after box have feature, they would help us add them.

[congminh1254]

Hi @skumaravelan

From the Camel owner, what is stoping them from instead of calling the getAppEnterpriseConnection, just use something like

    BoxDeveloperEditionAPIConnection connection = new BoxDeveloperEditionAPIConnection(enterpriseId,
        DeveloperEditionEntityType.ENTERPRISE, clientId, clientSecret, encryptionPref, accessTokenCache);
    connection.setProxy(proxy);
    connection.tryRestoreUsingAccessTokenCache();

I think it could achieve the same result?

[arjankowski]

Hi @skumaravelan,

Did you try using the code above from @congminh1254?

Regards,
Artur

[skumaravelan]

Hi
getAppEnterpriseConnection in https://github.com/box/box-java-sdk/blob/main/src/main/java/com/box/sdk/BoxDeveloperEditionAPIConnection.java#L121 does not let us do this . Box helper class https://github.com/apache/camel/blob/main/components/camel-box/camel-box-component/src/main/java/org/apache/camel/component/box/internal/BoxConnectionHelper.java#L279C86-L280C20 is calling connection.tryRestoreUsingAccessTokenCache(); In order to this to work, Box SDK needs a extended method with proxy arguments.