Add str methods call mutations and tests #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so in single responsibility reason in terms of this test, it will be much better to change upper() to title(), because title() not mutated
Contributor
Author
Contributor
Author
|
If it necessary I can fix last test to cover .upper() test case too, but more indexes (such as x_capitalize__mutmut_1, x_capitalize__mutmut_2, ..., x_capitalize__mutmut_n) can increase test complexity |
Otto-AA
reviewed
May 10, 2025
Collaborator
There was a problem hiding this comment.
Thanks, looks good to me!
I've only added some small remarks.
If it necessary I can fix last test to cover .upper() test case too, but more indexes (such as x_capitalize__mutmut_1, x_capitalize__mutmut_2, ..., x_capitalize__mutmut_n) can increase test complexity
No, your change is easier to read, let's leave it like that 👍
Co-authored-by: A_A <[email protected]>
… -> 'a.b.upper()'
Owner
|
Nice. @Otto-AA feel free to merge this when you are satisfied with it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add string methods as: