Tweak spin titles under debug #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Couldn't this extra newline to the title be handled inside the CaptureOutput constructor? That would cut this change down to 2 lines in one place, no? |
Collaborator
Author
|
Yes, it could. Lemme give that a spin. |
Collaborator
Author
|
@boxed, do you want me to rebase this PR to remove the first 5 commits? |
Owner
|
Yes please |
@boxed pointed out a better place to make the change was in the CatchOutput ctor itself, as that would make _all_ spinner titles debug sensitive with less code change.
CyberiaResurrection
force-pushed
the
SpinTitlesUnderDebug
branch
from
8d444cc to
93b4cd0
Compare
Collaborator
Author
|
That should be rebased now |
Owner
|
Thanks! |
Owner
|
I sent an invite to give you commit rights to mutmut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only really noticed this when reporting #419 , the bits in question being:
and
After more debug runs, I saw similar issues happened for
Generating mutants,Listing all testsandRunning stats.This PR should be quite simple to understand - the current status quo prevails when
mutmut.configis not set ormutmut.config.debugis False, but when it's True, append a newline to the spinner title in question so the next line of output starts on the next line, rather than appended to the end of the spinner title.Checking
mutmut.config is Nonefirst obviates the NoneType reference error that would otherwise occur - eg in mocked tests.