Handle -9 PyTest return code #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was more than a little weird - I was consistently getting a KeyError on line 589 of collect_stat, which maps return codes to a mutmut status. More digging into the underlying boomage revealed the mutant that caused it, along with the tests that rumbled it. For whatever reason, the process was getting killed _but not segfaulting_. This manifested as a -9 return code, and thus kaboom in collect_stat. To avoid generating another mutant status, and because "segfault" is the least-worst match, map the newly-problematic return code to "segfault".
Owner
|
Makes sense. Maybe the code should default to some "unknown kill state" for any return code it doesn't have a mapping for? Seems more robust. |
Collaborator
|
Is "suspicious" (code 35) a specific case? If not, we could use this one as the default. |
Owner
|
I think it is. But I can't remember anymore 😅 So sounds good to me. |
Collaborator
Author
|
@Otto-AA - "suspicious" is a specific state, so that may not work. I'll roll this PR up as is and then look at adding an "unknown" status in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was more than a little weird - I was consistently getting a KeyError on line 589 of collect_stat, which maps return codes to a mutmut status.
More digging into the underlying boomage revealed the mutant that caused it, along with the tests that rumbled it. For whatever reason, the process was getting killed but not segfaulting. This manifested as a -9 return code, and thus kaboom in collect_stat.
To avoid generating another mutant status, and because "segfault" is the least-worst match, map the newly-problematic return code to "segfault".