Fix unchanged string mutants #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As at the status quo, operator_string took the prefix of the node's value, trimming that off the rest to leave an approximation. This worked well enough until some wombat (hi) fed in a regex string consisting only of escape sequences and whitespace. For whatever reason, the node represented that value as r'(rest of text...) which the status quo dutifully trimmed to (rest of text...). As the two text strings didn't match, status quo dutifully let the mutant through despite it being a no-op. This commit adds an additional check to catch the _unmodified_ node value being equal to the mutated node value, skipping those candidate mutants.
Owner
|
Nice |
Collaborator
Author
|
Thanks for that @boxed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #435 , @Otto-AA stated that mutants being identical to the source code they're ostensibly mutating is a bug.
Again, I've tried to make the simplest, most tightly-focused, change I can think of to resolve the bug.