Use coverage to filter out mutations #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py is used to filter down mutations
We need to move up some other calls (copy_also_copy_files() and setup_source_paths()) so that their effects are in place when we do code coverage
Otto-AA
reviewed
Sep 12, 2025
Collaborator
Otto-AA
left a comment
Otto-AA
left a comment
There was a problem hiding this comment.
Thanks for this PR!
I skimmed through the diff and it looks good so far, only minor comments. I likely have time to test it out on the weekend.
e2e_projects/mutate_only_covered_lines/src/mutate_only_covered_lines/__init__.py
Show resolved
Hide resolved
Otto-AA
reviewed
Sep 12, 2025
Otto-AA
reviewed
Sep 12, 2025
I inspected the file generated in mutants and the "Bar" on line 10 is not mutated, but coverage.py reported that it wasn't covered, so the bug is in coverage.py.
Otto-AA
reviewed
Sep 13, 2025
Otto-AA
reviewed
Sep 13, 2025
Collaborator
|
Looks very good. While testing, I've found two bugs, but they were not related to this PR 🙃 I've added some more E2E tests, and a minor performance change (only calling Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #395
mutate_only_covered_linesso that the default behavior is NOT to use coverageThis works on my project and in the e2e one.