test(e2e): conftest helper + no-skip strategy for SDK entry / path_verification / exec_timeout

Moves the no-skip wiring from chore into #765 where the rest of the
test fixes already live.

- conftest.skip_or_fail_unless_sdk_build_required: helper that flips
  pytest.skip into pytest.fail when BOXLITE_E2E_REQUIRE_SDK_BUILDS=1
  is set. The e2e-cloud-test workflow sets it; local dev leaves it
  unset and the skip path stays usable.
- conftest.collect_ignore (guarded on BOXLITE_E2E_PROFILE != default):
  drops scripts/test/e2e/cases/test_path_verification.py from pytest
  collection on cloud profiles. Both cases in that file are LOCAL
  meta-tests (one asserts credentials.toml url=:3000, the other reads
  the host's boxlite-runner systemd journal) and can't run against
  the Tokyo ELB profile. collect_ignore drops them from collection
  entirely — no SKIP markers in the report.
- test_c_entry / test_cli_entry / test_cli_detach_recovery /
  test_go_entry / test_node_entry fixtures: every pytest.skip routed
  through skip_or_fail_unless_sdk_build_required.
- test_path_verification.py: module-level pytest.mark.skipif removed
  (replaced by the collect_ignore above so the file produces no
  collection at all on cloud, instead of being collected-then-skipped).
- test_exec_timeout.py: the _skipif_cloud decorator on both cases is
  gone; instead drain(ex) is moved behind a short asyncio.wait_for
  and reordered after ex.wait() so the elapsed / exit-code assertions
  don't depend on stream content. The REST runner's stream pumps
  don't reliably observe stream closure when the workload terminates
  via SIGKILL; the workaround lets the test actually run on cloud
  (no SKIP entry) while preserving its semantic intent.
- e2e-cloud-test.yml: BOXLITE_E2E_REQUIRE_SDK_BUILDS=1 on the
  Run E2E suite step — multi-job prereqs guarantee artifacts on
  disk so a fixture-skip path firing here is now a regression signal.

Author: G4614

.github/workflows/e2e-cloud-test.yml

@@ -493,9 +493,9 @@ jobs:
           # build_c / build_node / build_cli prereqs are now hard
           # dependencies of this job, so the C / Go / CLI / Node entry-
           # point fixtures always have their artifacts on disk. Flip
-          # skip→fail so a future regression in the build chain (or a
-          # missing download step) surfaces as a clear pytest failure
-          # instead of a silent SKIP that drains the gate.
+          # skip→fail (conftest.skip_or_fail_unless_sdk_build_required)
+          # so a future regression in the build chain or download step
+          # surfaces as a clear pytest failure instead of a silent SKIP.
           BOXLITE_E2E_REQUIRE_SDK_BUILDS: '1'
           # Tokyo Api (post-#758) supportedImages = the 3 ghcr-pinned
           # boxlite-agent-* digests only. The conftest default `alpine:3.23`

scripts/test/e2e/cases/conftest.py

@@ -58,6 +58,34 @@ def skip_or_fail_unless_sdk_build_required(reason: str) -> None:
 
 
 
+def skip_or_fail_unless_sdk_build_required(reason: str) -> None:
+    """SDK entry-point fixtures (test_c_entry, test_go_entry,
+    test_node_entry, test_cli_entry, test_cli_detach_recovery) skip
+    when their build artifact is missing — convenient for local dev
+    where someone hasn't built every SDK. On the cloud gate the
+    e2e-cloud-test workflow produces every artifact up front via
+    build_c / build_node / build_cli prereq jobs, so set
+    BOXLITE_E2E_REQUIRE_SDK_BUILDS=1 there — a regression in the
+    build step then surfaces as a test failure, not a silent skip."""
+    require = os.environ.get("BOXLITE_E2E_REQUIRE_SDK_BUILDS", "")
+    if require.lower() in ("1", "true", "yes", "on"):
+        pytest.fail(
+            f"BOXLITE_E2E_REQUIRE_SDK_BUILDS=1 forbids skipping this case "
+            f"but the prerequisite is missing: {reason}"
+        )
+    pytest.skip(reason)
+
+
+# test_path_verification.py is a LOCAL-only meta-test: case 1 asserts the
+# credentials.toml URL contains ':3000' (the local API port), case 2 reads
+# the host's `boxlite-runner` systemd journal via journalctl. Neither can
+# run against a remote profile pointing at the Tokyo ELB. Drop from pytest
+# collection on any non-default profile so the cloud gate reports them as
+# 'not collected' rather than producing SKIP entries.
+if DEFAULT_PROFILE != "default":
+    collect_ignore = ["test_path_verification.py"]
+
+
 def _profile(name: str) -> dict:
     if not CRED_PATH.exists():
         pytest.exit(

scripts/test/e2e/cases/test_exec_timeout.py

@@ -9,7 +9,7 @@
 SIGKILL — drain() blocks indefinitely on cloud while the underlying
 exec has long since exited. The exit-code / elapsed assertions don't
 depend on stream content, so a best-effort drain (3s ceiling) is
-enough to drain whatever the pump did emit without holding the test
+enough to flush whatever the pump did emit without holding the test
 hostage on the missing close signal. Tracked separately under the
 REST stream-pump teardown audit; the local FFI path is unaffected.
 """

scripts/test/e2e/cases/test_path_verification.py

@@ -18,7 +18,6 @@
 """
 from __future__ import annotations
 
-import os
 import sys
 from pathlib import Path
 
@@ -36,17 +35,10 @@
 #   (2) reads the local boxlite-runner systemd journal via journalctl —
 #       on the Tokyo cloud profile p1 the runner journal lives on an
 #       EC2 instance the test client can't reach.
-# Skip the whole module when the test session is configured against
-# anything other than the default (= local) profile so these don't
-# spam the cloud failure tally with environment-mismatch noise.
-pytestmark = pytest.mark.skipif(
-    os.environ.get("BOXLITE_E2E_PROFILE", "default") != "default",
-    reason=(
-        "LOCAL-only meta-test (checks credentials.toml url=:3000 and "
-        "reads host's boxlite-runner journalctl). Cannot run against a "
-        "remote profile."
-    ),
-)
+# Module-level skipif has been replaced by a conftest.collect_ignore
+# entry guarded on BOXLITE_E2E_PROFILE != 'default'. That stops pytest
+# from collecting this file at all on the cloud gate (no SKIP markers
+# in the report) rather than collecting + skipping.
 
 
 @pytest.mark.asyncio