Skip to content

Commit c22216d

Browse files
committed
ci(e2e-cloud): drop pull_request trigger
PR-on-open triggering serializes every PR against the shared Tokyo stack (see concurrency: e2e-cloud-shared, cancel-in-progress: false). The suite is slow enough that gating every PR open / push on it just queues runs behind each other for hours. Push-to-main keeps the post-merge regression signal; workflow_dispatch covers ad-hoc PR validation when wanted.
1 parent bbc1b09 commit c22216d

1 file changed

Lines changed: 10 additions & 14 deletions

File tree

.github/workflows/e2e-cloud.yml

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,31 +36,27 @@
3636

3737
name: E2E cloud
3838

39-
# No path filter on triggers: must always start so branch protection
40-
# can require this workflow's gate as a status check. Path matching
41-
# happens inside the `changes` job and gates the expensive `e2e` job.
39+
# Runs only on push-to-main and manual dispatch — PR triggering would
40+
# serialize every PR against the shared Tokyo stack (see concurrency
41+
# below), and the E2E suite is too slow to gate every PR on. Path
42+
# matching happens inside the `changes` job and gates the expensive
43+
# `e2e` job.
4244
on:
4345
push:
4446
branches: [main]
45-
pull_request:
46-
branches: [main]
4747
workflow_dispatch: {}
4848

49-
# Singleton lock — every run (every PR + every push) must serialize
50-
# against the SHARED Tokyo stack. Per-ref grouping is wrong here:
51-
# PR-A and PR-B have different refs but compete for the same ECS
52-
# service / runner binary / RDS row. cancel-in-progress: false because
53-
# a half-applied ECS rolling update is worse than waiting.
49+
# Singleton lock — every run must serialize against the SHARED Tokyo
50+
# stack. Per-ref grouping is wrong here: two merges to main race on
51+
# the same ECS service / runner binary / RDS row. cancel-in-progress:
52+
# false because a half-applied ECS rolling update is worse than waiting.
5453
concurrency:
5554
group: e2e-cloud-shared
5655
cancel-in-progress: false
5756

5857
env:
5958
# AWS identifiers come from repo variables (same pattern as
60-
# .github/workflows/e2e-test.yml). `vars.*` is stripped by GitHub
61-
# for fork-PR runs, but this workflow is gated on same-repo branches
62-
# (push to main + workflow_dispatch + same-repo PR), so the context
63-
# is always populated. Set via repo Settings → Variables:
59+
# .github/workflows/e2e-test.yml). Set via repo Settings → Variables:
6460
# AWS_ACCOUNT_ID, AWS_E2E_CLOUD_REGION, AWS_E2E_CLOUD_ROLE_ARN
6561
# Keeps the account ID out of the public repo source — defense in
6662
# depth (AWS treats account ID as "sensitive, not secret", but no

0 commit comments

Comments
 (0)