Error trapping for highlighting active layer in LayerChooserDropupMenu

[itspangler]

bug

i'm not sure if this was introduced recently or predated our latest sprint, but i just noticed that when you are using a historic atlas as a base layer, and then you try to search an address with the geocoder, this error is thrown:

index-_O3ZWfgj.js:2 Uncaught TypeError: Cannot read properties of undefined (reading 'id')

this error breaks the control drawer and prevents a user from manipulating "Atlases" and selecting other atlases. it's also reproducible if you set a base layer as a historic map and then pan to a new location

solution

i think we just need to introduce a logic in the geolocation process for if baseLayer is none, then load streets 2025

[itspangler]

okay, i actually looked at this and it's a consequence of

atlascope-v2/src/lib/mapControls/LayerChooserDropupMenu.svelte

Line 134 in d75eaae

class="text-gray-800 {choice.id === currentLayer.id ? 'bg-slate-100' : ''} cursor-pointer select-none relative py-2 pl-3 pr-9 hover:text-red-900"

, where it fails to get an id value when "No layer" appears. should be an easy fix

[itspangler]

okay @garrettdashnelson , can you take a look at the very small change at this branch to affirm 1) that you can reproduce the problem and 2) that this fixes it?

40d571c

[garrettdashnelson]

@itspangler I think you correctly diagnosed this; it's not because of anything having to do with georeferencing, but from when the current background layer is not actually available in the menu since it's got 0% availability. I can confirm that your fix seems to work fine for me, so feel free to put in a PR to merge it in!