Flow elements container errors and warnings not visible

[jhajkom]

Describe the Bug

This bug occurs when a user navigates to a location of the BPMN designer where the flow elements container (djs-overlay-container) is out of view.

I have also noticed that this (form elements container) can also overlap a diagram which is confusing to the users.

This means that a user may have solved all errors and warnings visible but will still see that there are errors or warnings left. In this case they cannot see what the errors or warnings are.

I noticed that the errors / warnings sit in and djs-overlay-container and are always in the same location, unless the errors / warnings are attached to an element in the diagram.

Steps to Reproduce

I can reproduce the error with the playground project.

1. Checkout the bpmnlint-playground project
2. npm install and npm start
3. After navigating to localhost:8080 a diagram is presented to you.
4. Highlight the diagram by pressing and holding shift and using the mouse select all the diagram elements
5. Now move all the elements to the right. (a large distance)
6. Select a start event and drag it to the diagram
7. Give the start event a name and connect it to something (the first task for example)
8. Validate the BPMN again. You will see 1 error and 6 warnings.
9. Warnings are visible however the error is not.

Expected Behavior

The flow elements container errors/warnings should always be visible, regardless where the diagram is placed on the canvas.

Environment

• Host (Browser/Node version), if applicable: Chrome 81.0.4044.138
• OS: macOS Mojave 10.14.6
• Library version: latest

[nikku]

Thanks for opening this issue @jhajkom.

Unfortunately this is something hard to workaround, as we use the existing overlay infrastructure provided by diagram-js to place the dot.

What do you think for an alternative solution, i.e. a control that allows you to toggle through all the errors (and ensuring that the respective element is visible)?

From a users point of view looping through all errors / warnings could have additional benefits, too.

[jhajkom]

Thank you for your fast response @nikku

Toggling through the errors doesn't sound like a bad alternative solution. This is something that was brought up within my own team as a possible future feature. It would be cool if it was included in this.

I was also wondering, would it be possible to place it next to the linting button as it is displayed here:

Reference here.

If not, is there any way to maybe calculate the coordinates of the first element in the diagram and display the dot close to that? (wild idea I know, just exploring possibilities)

Thank you