Skip to content

Commit f497627

Browse files
committed
chore: outsource builtins
Related to camunda/camunda-modeler#3983
1 parent 2f7eda1 commit f497627

8 files changed

Lines changed: 23 additions & 1183 deletions

File tree

package-lock.json

Lines changed: 12 additions & 571 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,10 @@
99
"module": "dist/index.es.js",
1010
"scripts": {
1111
"all": "run-s lint test build",
12-
"compile:builtins": "node scripts/compileBuiltins.js",
1312
"test": "karma start",
1413
"build": "rollup -c --bundleConfigAsCjs",
1514
"build:watch": "npm run build -- -w",
16-
"builtins": "run-s pull:platform-docs compile:builtins",
1715
"lint": "eslint .",
18-
"pull:platform-docs": "git -C camunda-platform-docs pull || git clone git@github.com:camunda/camunda-platform-docs.git camunda-platform-docs",
1916
"start": "cross-env SINGLE_START=true npm run dev",
2017
"start:camunda": "cross-env SINGLE_START=camunda npm run dev",
2118
"dev": "npm test -- --auto-watch --no-single-run",
@@ -49,6 +46,7 @@
4946
"license": "MIT",
5047
"dependencies": {
5148
"@bpmn-io/feel-lint": "^1.4.0",
49+
"@camunda/feel-builtins": "^0.2.0",
5250
"@codemirror/autocomplete": "^6.16.2",
5351
"@codemirror/commands": "^6.8.0",
5452
"@codemirror/language": "^6.10.2",
@@ -71,7 +69,6 @@
7169
"cross-env": "^7.0.3",
7270
"eslint": "^8.57.0",
7371
"eslint-plugin-bpmn-io": "^1.0.0",
74-
"glob": "^11.0.1",
7572
"karma": "^6.4.4",
7673
"karma-chrome-launcher": "^3.2.0",
7774
"karma-coverage": "^2.2.1",
@@ -81,7 +78,6 @@
8178
"karma-mocha": "^2.0.1",
8279
"karma-sinon-chai": "^2.0.2",
8380
"karma-webpack": "^5.0.1",
84-
"marked": "^9.1.6",
8581
"mocha": "^10.8.2",
8682
"mocha-test-container-support": "^0.2.0",
8783
"npm-run-all": "^4.1.5",

scripts/compileBuiltins.js

Lines changed: 0 additions & 44 deletions
This file was deleted.

src/builtins/camunda.json

Lines changed: 0 additions & 506 deletions
This file was deleted.

src/builtins/index.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
import camundaTags from './camunda.json';
1+
import { domify } from 'min-dom';
2+
import { camundaBuiltins } from '@camunda/feel-builtins';
23

3-
import { parseBuiltins } from './util';
4-
5-
export const camunda = parseBuiltins(camundaTags);
4+
export const domifiedBuiltins = camundaBuiltins.map(builtin => ({
5+
...builtin,
6+
info: () => domify(builtin.info),
7+
}));

src/builtins/util.js

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/index.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import theme from './theme';
1010

1111
import * as Core from './core';
1212

13-
import { camunda as camundaBuiltins } from './builtins';
13+
import { domifiedBuiltins } from './builtins';
1414

1515
/**
1616
* @typedef { import('./core').Variable } Variable
@@ -21,12 +21,6 @@ import { camunda as camundaBuiltins } from './builtins';
2121
* @typedef { import('./language').ParserDialect } ParserDialect
2222
*/
2323

24-
/**
25-
* @typedef {object} Builtin
26-
* @property {string} name
27-
* @property {string} description
28-
*/
29-
3024
const coreConf = new Compartment();
3125
const placeholderConf = new Compartment();
3226

@@ -61,7 +55,7 @@ export default function FeelEditor({
6155
placeholder = '',
6256
readOnly = false,
6357
value = '',
64-
builtins = camundaBuiltins,
58+
builtins = domifiedBuiltins,
6559
variables = []
6660
}) {
6761

test/spec/autocompletion/builtin.spec.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ import {
44

55
import { EditorState } from '@codemirror/state';
66
import { variableCompletion } from '../../../src/autocompletion/variable';
7-
8-
import {
9-
camunda as camundaBuiltins
10-
} from '../../../src/builtins';
7+
import { domifiedBuiltins } from '../../../src/builtins';
118

129

1310
describe('autocompletion - built-ins', function() {
@@ -147,7 +144,7 @@ describe('autocompletion - built-ins', function() {
147144
*
148145
* @return { CompleteFn }
149146
*/
150-
function setup(doc, builtins = camundaBuiltins) {
147+
function setup(doc, builtins = domifiedBuiltins) {
151148

152149
const completion = variableCompletion({
153150
builtins

0 commit comments

Comments
 (0)