Skip to content

Commit ac11012

Browse files
authored
Feat: PHP 8.4 compatibility (#9)
1 parent 9f56859 commit ac11012

File tree

6 files changed

+19
-16
lines changed

6 files changed

+19
-16
lines changed

.github/workflows/ci-workflow.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ on:
99
jobs:
1010
code-style:
1111
name: Code Style & Static Analysis
12-
runs-on: ubuntu-20.04
12+
runs-on: ubuntu-latest
1313
steps:
1414
- name: Checkout
15-
uses: actions/checkout@v2
15+
uses: actions/checkout@v4
1616

1717
- name: Setup PHP
1818
uses: shivammathur/setup-php@v2
1919
with:
20-
php-version: 7.1
20+
php-version: 8.4
2121
extensions: mbstring, pcntl
2222

2323
- name: Validate composer.json and composer.lock
@@ -32,7 +32,7 @@ jobs:
3232

3333
tests:
3434
name: Test Suite
35-
runs-on: ubuntu-20.04
35+
runs-on: ubuntu-latest
3636
strategy:
3737
max-parallel: 10
3838
matrix:
@@ -43,10 +43,13 @@ jobs:
4343
- 7.4
4444
- 8.0
4545
- 8.1
46+
- 8.2
47+
- 8.3
48+
- 8.4
4649

4750
steps:
4851
- name: Checkout
49-
uses: actions/checkout@v2
52+
uses: actions/checkout@v4
5053

5154
- name: Setup PHP
5255
uses: shivammathur/setup-php@v2

src/Pairs.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public function __construct(
3434
string $queryString,
3535
bool $decodeKeys = false,
3636
bool $decodeValues = false,
37-
string $separator = null
37+
?string $separator = null
3838
) {
3939

4040
$this->queryString = $queryString;

src/QueryString.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ private static function createFromString(string $string, QueryStringParserInterf
7878
* @return QueryString
7979
* @throws \RuntimeException
8080
*/
81-
public static function createFromCurrentLocation(QueryStringParserInterface $queryStringParser = null): self
81+
public static function createFromCurrentLocation(?QueryStringParserInterface $queryStringParser = null): self
8282
{
8383
if (!isset($_SERVER['REQUEST_URI'])) {
8484
throw new \RuntimeException('$_SERVER[\'REQUEST_URI\'] has not been set.');
@@ -102,7 +102,7 @@ public function withCurrentLocation(): self
102102
* @throws \InvalidArgumentException
103103
* @throws \TypeError
104104
*/
105-
public static function factory($input = null, QueryStringParserInterface $queryStringParser = null): self
105+
public static function factory($input = null, ?QueryStringParserInterface $queryStringParser = null): self
106106
{
107107
if (is_array($input)) {
108108
return self::createFromParams($input);

src/Renderer/ArrayValuesNormalizerRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ final class ArrayValuesNormalizerRenderer implements QueryStringRendererInterfac
1616
/**
1717
* ArrayValuesStringifier constructor.
1818
*/
19-
protected function __construct(QueryStringRendererInterface $renderer = null)
19+
protected function __construct(?QueryStringRendererInterface $renderer = null)
2020
{
2121
$this->renderer = $renderer;
2222
}
2323

24-
public static function factory(QueryStringRendererInterface $renderer = null)
24+
public static function factory(?QueryStringRendererInterface $renderer = null)
2525
{
2626
return new self($renderer ?? NativeRenderer::factory());
2727
}

src/Renderer/FlatRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ final class FlatRenderer implements QueryStringRendererInterface
1111
*/
1212
private $renderer;
1313

14-
protected function __construct(QueryStringRendererInterface $renderer = null)
14+
protected function __construct(?QueryStringRendererInterface $renderer = null)
1515
{
1616
$this->renderer = $renderer;
1717
}
1818

19-
public static function factory(QueryStringRendererInterface $renderer = null)
19+
public static function factory(?QueryStringRendererInterface $renderer = null)
2020
{
2121
return new self($renderer ?? NativeRenderer::factory());
2222
}

src/functions.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* @return QueryString
1313
* @throws \InvalidArgumentException
1414
*/
15-
function query_string($input = null, QueryStringParserInterface $queryStringParser = null): QueryString
15+
function query_string($input = null, ?QueryStringParserInterface $queryStringParser = null): QueryString
1616
{
1717
return QueryString::factory($input, $queryStringParser);
1818
}
@@ -21,7 +21,7 @@ function query_string($input = null, QueryStringParserInterface $queryStringPars
2121
* @param QueryStringRendererInterface|null $renderer
2222
* @return ArrayValuesNormalizerRenderer
2323
*/
24-
function withoutNumericIndices(QueryStringRendererInterface $renderer = null): ArrayValuesNormalizerRenderer
24+
function withoutNumericIndices(?QueryStringRendererInterface $renderer = null): ArrayValuesNormalizerRenderer
2525
{
2626
return ArrayValuesNormalizerRenderer::factory($renderer);
2727
}
@@ -30,7 +30,7 @@ function withoutNumericIndices(QueryStringRendererInterface $renderer = null): A
3030
* @param QueryStringRendererInterface|null $renderer
3131
* @return FlatRenderer
3232
*/
33-
function flat(QueryStringRendererInterface $renderer = null): FlatRenderer
33+
function flat(?QueryStringRendererInterface $renderer = null): FlatRenderer
3434
{
3535
return FlatRenderer::factory($renderer);
3636
}
@@ -42,7 +42,7 @@ function flat(QueryStringRendererInterface $renderer = null): FlatRenderer
4242
* @param string|null $separator
4343
* @return Pairs
4444
*/
45-
function pairs(string $queryString, bool $decodeKeys = false, bool $decodeValues = false, string $separator = null): Pairs
45+
function pairs(string $queryString, bool $decodeKeys = false, bool $decodeValues = false, ?string $separator = null): Pairs
4646
{
4747
return new Pairs($queryString, $decodeKeys, $decodeValues, $separator);
4848
}

0 commit comments

Comments
 (0)