Skip to content

Commit 4038c6b

Browse files
bpwhelanclaude
andcommitted
Fix TestPythonApp CI failures on all three platforms
- macOS arm64: replace setup-ffmpeg action (x64-only) with brew install - Cron scheduler tests: start db_write_queue in conftest so _execute_safe can process queued tasks; without it events never fired within timeout - Stats dashboard test: reading_speed is now 79 (single-line sessions no longer contribute to active_time, changing the weighted average) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 952279f commit 4038c6b

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

.github/workflows/test_python.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,12 @@ jobs:
4949
- name: Sync dependencies (project + dev)
5050
run: uv sync --extra dev
5151

52-
- name: Install ffmpeg
52+
- name: Install ffmpeg (macOS)
53+
if: runner.os == 'macOS'
54+
run: brew install ffmpeg
55+
56+
- name: Install ffmpeg (non-macOS)
57+
if: runner.os != 'macOS'
5358
uses: federicocarboni/setup-ffmpeg@v3
5459

5560
# - name: Check Python formatting

tests/util/cron/conftest.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import pytest
2+
3+
4+
@pytest.fixture(autouse=True)
5+
def _ensure_db_write_queue_running():
6+
from GameSentenceMiner.util.database.write_queue import db_write_queue
7+
db_write_queue.start()
8+
yield

tests/web/test_stats_dashboard_e2e.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ def test_api_stats_full_flow_returns_expected_dashboard_contract(
436436
assert all_games["total_characters"] == 132
437437
assert all_games["total_sentences"] == 10
438438
assert all_games["total_time_hours"] == pytest.approx(1.675)
439-
assert all_games["reading_speed"] == 78
439+
assert all_games["reading_speed"] == 79
440440
assert all_games["sessions"] == 4
441441
assert all_games["completed_games"] == 1
442442
assert all_games["first_date"] == "2026-03-10"

0 commit comments

Comments
 (0)