Skip to content

Commit 894bf72

Browse files
authored
Merge pull request PHPCSStandards#828 from PHPCSStandards/feature/squiz-membervarspacing-readonly
Squiz/MemberVarSpacing: allow for PHP 8.1+ readonly properties
2 parents ce20d6a + 4ed2199 commit 894bf72

File tree

4 files changed

+23
-0
lines changed

4 files changed

+23
-0
lines changed

src/Standards/Squiz/Sniffs/WhiteSpace/MemberVarSpacingSniff.php

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ protected function processMemberVar(File $phpcsFile, $stackPtr)
4747

4848
$validPrefixes = Tokens::$methodPrefixes;
4949
$validPrefixes[] = T_VAR;
50+
$validPrefixes[] = T_READONLY;
5051

5152
$startOfStatement = $phpcsFile->findPrevious($validPrefixes, ($stackPtr - 1), null, false, null, true);
5253
if ($startOfStatement === false) {

src/Standards/Squiz/Tests/WhiteSpace/MemberVarSpacingUnitTest.inc

+7
Original file line numberDiff line numberDiff line change
@@ -372,3 +372,10 @@ enum SomeEnum
372372

373373
case ONE = 'one';
374374
}
375+
376+
class SupportReadonlyProperties {
377+
readonly int $readonlyA;
378+
public readonly string $publicReadonly;
379+
readonly bool $readonlyB;
380+
readonly private bool $readonlyPrivate;
381+
}

src/Standards/Squiz/Tests/WhiteSpace/MemberVarSpacingUnitTest.inc.fixed

+11
Original file line numberDiff line numberDiff line change
@@ -357,3 +357,14 @@ enum SomeEnum
357357

358358
case ONE = 'one';
359359
}
360+
361+
class SupportReadonlyProperties {
362+
363+
readonly int $readonlyA;
364+
365+
public readonly string $publicReadonly;
366+
367+
readonly bool $readonlyB;
368+
369+
readonly private bool $readonlyPrivate;
370+
}

src/Standards/Squiz/Tests/WhiteSpace/MemberVarSpacingUnitTest.php

+4
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ public function getErrorList()
6767
353 => 1,
6868
357 => 1,
6969
366 => 1,
70+
377 => 1,
71+
378 => 1,
72+
379 => 1,
73+
380 => 1,
7074
];
7175

7276
}//end getErrorList()

0 commit comments

Comments
 (0)