Skip to content

App stats #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

App stats #42

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe84947
service info check
bhatiadheeraj Apr 19, 2022
fffd61b
date check forloop
bhatiadheeraj Apr 21, 2022
47c4f0d
date checking and avoiding duplicate data
bhatiadheeraj Apr 21, 2022
bab82ca
removed log statements
bhatiadheeraj Apr 21, 2022
4c5feac
refactored code
bhatiadheeraj Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ var serviceinfoSchema = mongoose.Schema({
success_rate: Number,

readme_status: String, //I think I am going to deprecate this (by status/status_msg)
monthlyCounts: [Number] //
});
exports.Serviceinfo = mongoose.model('Serviceinfo', serviceinfoSchema);

68 changes: 67 additions & 1 deletion bin/serviceinfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ db.init(function(err) {
}
}
service_info[status._id.service].counts[status._id.status] = status.count;

//calculate success_rate
let finished = service_info[status._id.service].counts.finished;
let failed = service_info[status._id.service].counts.failed;
Expand Down Expand Up @@ -120,6 +119,73 @@ db.init(function(err) {
});
},

async next=>{
/* Get all service info */
db.Serviceinfo.find({}).exec((err,services)=>{
if(err) return next(err);
services.forEach(async(service)=>{
let countData;
const currentDate = new Date();
if(!service.monthlyCounts || !service.monthlyCounts.length) {
Copy link
Contributor

@soichih soichih Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a way to combine these 2 giant if statements into one. :) Can you think of a way?

service.monthlyCounts = [];
//if no monthly count then add data from 2017
for(let year = 2017; year <= currentDate.getFullYear(); year++){
for(let month = 1; month <=12; month++){
if(year == currentDate.getFullYear() && month > currentDate.getMonth()+1) break;
const start = new Date(year+"-"+month+"-01");
const end = new Date(start);
end.setMonth(end.getMonth()+1);
countData = await db.Task.aggregate([
{$match: {
create_date: {$gte: start, $lt: end},
service: service.service
}},{
$group: {
_id: {service: "$service"},
count: {$sum: 1},
walltime: {$sum: "$runtime"}
}
}
]);
if(!countData.length) service.monthlyCounts.push(undefined);
else service.monthlyCounts.push(countData[0].count);
}
}
// console.log(service.service,service.monthlyCounts.length);
service.save();
} else {
//if the month is already marked then updating it instead of pushing element
const start = currentDate;
const end = new Date(start);
start.setMonth(end.getMonth()-1);
const month_difference = (end.getFullYear() - new Date('2017-01-01').getFullYear())*12 + (end.getMonth() - new Date('2017-01-01').getMonth()) - 1;
countData = await db.Task.aggregate([
{$match: {
create_date: {$gte: start, $lt: end},
service: service.service
}},{
$group: {
_id: {service: "$service"},
count: {$sum: 1},
walltime: {$sum: "$runtime"}
}
}
]);

/* if index exists then update else push values*/
if(service.monthlyCounts[month_difference] == undefined || service.monthlyCounts[month_difference]) {
if(!countData.length) service.monthlyCounts[month_difference] = undefined;
else service.monthlyCounts[month_difference] = countData[0].count;
} else {
if(!countData.length) service.monthlyCounts.push(undefined);
else service.monthlyCounts.push(countData[0].count);
}
service.save();
}
});
});
},


/* not useful?
next=>{
Expand Down