Skip to content

Commit 5962bae

Browse files
authored
feature: update browser switch version (#111)
* feature: add new version of browser switch * fix: add CHANGELOG entry * fix: wait for text to exist before asserting
1 parent 6463d40 commit 5962bae

4 files changed

Lines changed: 10 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# PopupBridge Android Release Notes
22

3+
## unreleased
4+
5+
* Bump `browser-switch` to 3.5.1
6+
* Upgrade `compileSdkVersion` to API 36
7+
38
## 5.1.0
49

510
* Fix an issue where the WebViewClient is being silently overridden. [#95](https://github.com/braintree/popup-bridge-android/issues/95)

Demo/src/androidTest/java/com/braintreepayments/popupbridge/demo/test/PopupBridgeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public void opensPopup_whenClickingDontLikeAnyOfTheseColors_returnsCanceledSelec
4747
onViewWithText("Launch Popup").perform(click());
4848
onViewWithText("I don't like any of these colors")
4949
.waitForExists(BROWSER_TIMEOUT).perform(click());
50-
assertTrue(onDevice(withText("You did not like any of our colors")).exists());
50+
assertTrue(onDevice(withText("You did not like any of our colors")).waitForExists(BROWSER_TIMEOUT).exists());
5151
}
5252

5353
@Test(timeout = 50000)
@@ -56,7 +56,7 @@ public void opensPopup_whenClickingBack_returnsCanceledSelection() {
5656
onViewWithText("I don't like any of these colors")
5757
.waitForExists(BROWSER_TIMEOUT);
5858
onDevice().pressBack();
59-
assertTrue(onDevice(withText("You did not choose a color")).exists());
59+
assertTrue(onDevice(withText("You did not choose a color")).waitForExists(BROWSER_TIMEOUT).exists());
6060
}
6161

6262
private void testColor(String color) {

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ version = '5.1.1-SNAPSHOT'
2525
group = "com.braintreepayments"
2626

2727
ext {
28-
compileSdkVersion = 35
28+
compileSdkVersion = 36
2929
minSdkVersion = 23
3030
targetSdkVersion = 35
3131
versionCode = 18

gradle/libs.versions.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
[versions]
22
# Demo App
33
appcompatVersion = "1.7.0"
4-
browserSwitchVersion = "3.0.0"
4+
browserSwitchVersion = "3.5.1"
55
coreVersion = "1.6.1"
66
datastorePreferencesVersion = "1.1.4"
77
detekt = "1.23.6"
88
deviceAutomatorVersion = "1.0.0"
9-
gradleVersion = "8.9.0"
9+
gradleVersion = "8.9.1"
1010
junitVersion = "4.13.2"
1111
kotlinAndroidVersion = "2.1.10"
1212
kotlinxCoroutinesTestVersion = "1.10.2"

0 commit comments

Comments
 (0)