[BUG] Sequential build and publish deleting nuget packages

[sergeyshaykhullin]

Describe the bug
Each build and push step deletes all nuget packages from previous one

Failed Action Log URL (Required)
https://github.com/appany/AppAny.Quartz.EntityFrameworkCore.Migrations/runs/1913414360?check_suite_focus=true

To Reproduce

1. Build and publish first package
2. Build and publish second package
3. Create release
4. Try to upload first .nuget to artifacts
5. BOOM

Expected Behavior
Each build step has its own directory for .nuget files and do not delete previous

The workaround is to reorder steps

Here is the problem

publish-nuget/index.js

Line 58 in c12b854

fs.readdirSync(".").filter(fn => /\.s?nupkg$/.test(fn)).forEach(fn => fs.unlinkSync(fn))

Environment:

• Platform [e.g. Windows / Linux]
• Action Version [e.g. v2.5.3]

[AraHaan]

@sergeyshaykhullin those logs expired.

[AraHaan]

I think a simple fix for this is to remove .forEach(fn => fs.unlinkSync(fn)) since usually people add nupkg's and snupkg's to their .gitignore. If they did not that is their fault if they use an action that commits them to the repository. Wait no I will just change that line to depend on the projectFile variable that it points to on that path.

[sergeyshaykhullin]

No, because if you will not delete previous nuget files you will try to push them again

publish-nuget/index.js

Line 67 in c12b854

const pushCmd = `dotnet nuget push *.nupkg -s ${this.nugetSource}/v3/index.json -k ${this.nugetKey} --skip-duplicate ${!this.includeSymbols ? "-n 1" : ""}`,

[AraHaan]

So basically I guess one way to fix that is to nuke them after publish.

[sergeyshaykhullin]

@AraHaan No, i suggest to

Each build step has its own directory for .nuget files and do not delete previous

Randomly generate directories foreach GitHub Action run

So if you have:

- uses: brandedoutcast/publish-nuget@v2
  ...

- uses: brandedoutcast/publish-nuget@v2
  ...

You will have:

.../random/path/1/*.nuget

.../random/path/2/*.nuget

It means that:

1. _pushPackage should generate random directory
2. -o { directory }

   publish-nuget/index.js

   Line 62 in c12b854

   this._executeInProcess(`dotnet pack ${this.includeSymbols ? "--include-symbols -p:SymbolPackageFormat=snupkg" : ""} --no-build -c Release ${this.projectFile} -o .`)

3. push { directory }/*.nuget

   publish-nuget/index.js

   Line 67 in c12b854

   const pushCmd = `dotnet nuget push *.nupkg -s ${this.nugetSource}/v3/index.json -k ${this.nugetKey} --skip-duplicate ${!this.includeSymbols ? "-n 1" : ""}`,

4. readDirSync('{ directory }')

   publish-nuget/index.js

   Line 64 in c12b854

   const packages = fs.readdirSync(".").filter(fn => fn.endsWith("nupkg"))

5. Something what i missed

[sergeyshaykhullin]

Also, as i know, this repo is abandoned

@drusellers What do you think about this changes?

[AraHaan]

I got a better idea and updated #61 accordingly. It might be a bit of a hack however.

[AraHaan]

Alright merged into my fork.