Repository navigation
Commit c311cff
committed
Address review feedback on datetime masked ops
- Fill in docstrings for the datetime helpers and tests (drop the TODO
placeholders); annotate the new lowering functions.
- Delegate temporal *comparisons* (not just +/-) to numba-cuda-mlir's
unit-aware scalar lowering so mixed-unit compares are correct
(e.g. 1s > 2ns is True, not a raw 1 > 2); add a mixed-unit test.
(CodeRabbit NVIDIA#23309)
- Key datetime staging temp vars off the unique result ``target`` so two
temporal ops sharing a left operand in one expression can't clobber
each other's typemap entries; drop the now-redundant ref_var plumbing
and de-specialize the _make_temp_var name prefix. (CodeRabbit NVIDIA#23309)
- Drop the redundant ``ref`` param from the datetime comparison test,
asserting via the op directly (prior-PR review pattern).1 parent b0c5eb2 commit c311cff
3 files changed
Lines changed: 88 additions & 43 deletions
File tree
- python/cudf/cudf
- core/udf/mlir_backend
- tests/private_objects/mlir_backend
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
207 | 219 | | |
208 | 220 | | |
209 | 221 | | |
210 | 222 | | |
211 | 223 | | |
212 | 224 | | |
213 | 225 | | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
226 | 246 | | |
227 | 247 | | |
228 | 248 | | |
| |||
231 | 251 | | |
232 | 252 | | |
233 | 253 | | |
234 | | - | |
235 | | - | |
236 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
237 | 258 | | |
238 | 259 | | |
239 | 260 | | |
| |||
253 | 274 | | |
254 | 275 | | |
255 | 276 | | |
256 | | - | |
257 | 277 | | |
258 | 278 | | |
259 | 279 | | |
260 | 280 | | |
261 | 281 | | |
262 | | - | |
263 | | - | |
| 282 | + | |
| 283 | + | |
264 | 284 | | |
265 | 285 | | |
266 | 286 | | |
267 | | - | |
268 | 287 | | |
269 | 288 | | |
270 | 289 | | |
| |||
277 | 296 | | |
278 | 297 | | |
279 | 298 | | |
280 | | - | |
281 | 299 | | |
282 | 300 | | |
283 | 301 | | |
| |||
320 | 338 | | |
321 | 339 | | |
322 | 340 | | |
323 | | - | |
324 | 341 | | |
325 | 342 | | |
326 | 343 | | |
| |||
383 | 400 | | |
384 | 401 | | |
385 | 402 | | |
386 | | - | |
387 | 403 | | |
388 | 404 | | |
389 | 405 | | |
| |||
396 | 412 | | |
397 | 413 | | |
398 | 414 | | |
399 | | - | |
400 | 415 | | |
401 | 416 | | |
402 | 417 | | |
| |||
424 | 439 | | |
425 | 440 | | |
426 | 441 | | |
427 | | - | |
| 442 | + | |
428 | 443 | | |
429 | | - | |
430 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
431 | 447 | | |
432 | 448 | | |
433 | 449 | | |
434 | | - | |
| 450 | + | |
435 | 451 | | |
436 | 452 | | |
437 | 453 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
817 | 817 | | |
818 | 818 | | |
819 | 819 | | |
820 | | - | |
| 820 | + | |
821 | 821 | | |
822 | 822 | | |
823 | 823 | | |
| |||
850 | 850 | | |
851 | 851 | | |
852 | 852 | | |
853 | | - | |
| 853 | + | |
854 | 854 | | |
855 | 855 | | |
856 | 856 | | |
| |||
870 | 870 | | |
871 | 871 | | |
872 | 872 | | |
873 | | - | |
| 873 | + | |
874 | 874 | | |
875 | 875 | | |
876 | 876 | | |
| |||
889 | 889 | | |
890 | 890 | | |
891 | 891 | | |
892 | | - | |
893 | | - | |
894 | | - | |
895 | | - | |
896 | | - | |
897 | | - | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
898 | 895 | | |
899 | 896 | | |
900 | 897 | | |
| |||
910 | 907 | | |
911 | 908 | | |
912 | 909 | | |
913 | | - | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
914 | 939 | | |
915 | 940 | | |
916 | 941 | | |
917 | | - | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
918 | 945 | | |
919 | 946 | | |
920 | 947 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| |||
0 commit comments