Skip to content

Commit 310c601

Browse files
committed
Sync datastore config defaults with kine CLI
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 10e3d40) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
1 parent 286aa9f commit 310c601

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

pkg/cli/server/server.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,12 +150,17 @@ func run(app *cli.Context, cfg *cmds.Server, leaderControllers server.CustomCont
150150
serverConfig.ControlConfig.ExtraEtcdArgs = cfg.ExtraEtcdArgs.Value()
151151
serverConfig.ControlConfig.ExtraSchedulerAPIArgs = cfg.ExtraSchedulerArgs.Value()
152152
serverConfig.ControlConfig.ClusterDomain = cfg.ClusterDomain
153-
serverConfig.ControlConfig.Datastore.NotifyInterval = 5 * time.Second
154-
serverConfig.ControlConfig.Datastore.EmulatedETCDVersion = etcdversion.Version
155-
serverConfig.ControlConfig.Datastore.Endpoint = cfg.DatastoreEndpoint
156153
serverConfig.ControlConfig.Datastore.BackendTLSConfig.CAFile = cfg.DatastoreCAFile
157154
serverConfig.ControlConfig.Datastore.BackendTLSConfig.CertFile = cfg.DatastoreCertFile
158155
serverConfig.ControlConfig.Datastore.BackendTLSConfig.KeyFile = cfg.DatastoreKeyFile
156+
serverConfig.ControlConfig.Datastore.CompactBatchSize = 1000
157+
serverConfig.ControlConfig.Datastore.CompactInterval = 5 * time.Minute
158+
serverConfig.ControlConfig.Datastore.CompactMinRetain = 1000
159+
serverConfig.ControlConfig.Datastore.CompactTimeout = 5 * time.Second
160+
serverConfig.ControlConfig.Datastore.EmulatedETCDVersion = etcdversion.Version
161+
serverConfig.ControlConfig.Datastore.Endpoint = cfg.DatastoreEndpoint
162+
serverConfig.ControlConfig.Datastore.NotifyInterval = 5 * time.Second
163+
serverConfig.ControlConfig.Datastore.PollBatchSize = 500
159164
serverConfig.ControlConfig.KineTLS = cfg.KineTLS
160165
serverConfig.ControlConfig.AdvertiseIP = cfg.AdvertiseIP
161166
serverConfig.ControlConfig.AdvertisePort = cfg.AdvertisePort

pkg/daemons/control/server_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ import (
1919
"github.com/k3s-io/k3s/pkg/etcd"
2020
testutil "github.com/k3s-io/k3s/tests"
2121
"github.com/k3s-io/k3s/tests/mock"
22+
"github.com/k3s-io/kine/pkg/endpoint"
2223
pkgerrors "github.com/pkg/errors"
24+
etcdversion "go.etcd.io/etcd/api/v3/version"
2325
utilnet "k8s.io/apimachinery/pkg/util/net"
2426
"k8s.io/apiserver/pkg/authentication/authenticator"
2527
"k8s.io/apiserver/pkg/authentication/request/anonymous"
@@ -183,6 +185,15 @@ func mockControl(ctx context.Context, t *testing.T, clusterInit bool) (*config.C
183185
ServerNodeName: "k3s-server-1",
184186
ServiceNodePortRange: &utilnet.PortRange{Base: 30000, Size: 2048},
185187
Token: "token",
188+
Datastore: endpoint.Config{
189+
CompactBatchSize: 1000,
190+
CompactInterval: 5 * time.Minute,
191+
CompactMinRetain: 1000,
192+
CompactTimeout: 5 * time.Second,
193+
EmulatedETCDVersion: etcdversion.Version,
194+
NotifyInterval: 5 * time.Second,
195+
PollBatchSize: 500,
196+
},
186197
}
187198

188199
if err := os.Chdir(control.DataDir); err != nil {

0 commit comments

Comments
 (0)