Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Japanese today.rateBraveCardTitle has a different meaning #8759

Closed
@ski-u

Description

Description:

Hi, from Japan 👋

Japanese today.rateBraveCardTitle is now "Braveをリンクしますか?"
However that doesn't mean "Liking Brave?" but "Linking Brave?" in Japanese!

Steps to Reproduce

  1. Language setting should be Japanse

Actual result:

Expected result:

  • It seems that rateBraveCardTitle should mean "Liking Brave?"

    public static let rateBraveCardTitle = NSLocalizedString(
    "today.rateBraveCardTitle",
    tableName: "BraveShared",
    bundle: .module,
    value: "Liking Brave?",
    comment: "Title shown on the Rate Brave Card "
    )

  • I can suggest more suitable wording like "Braveを気に入っていますか?"

Reproduces how often: [Easily reproduced, Intermittent Issue]

  • Easily reproduced

Brave Version:

  • v1.61.1 (24.1.4.20)
  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?: Yes

Device details:

iPhone11,8 (iOS 16.7.2)

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions