keep it simple

choose calculator when calculateDigits is called

Author: tonicospinelli

src/Cns.php

@@ -3,7 +3,7 @@
 namespace Brazanation\Documents;
 
 use Brazanation\Documents\Cns\CnsCalculator;
-use Brazanation\Documents\Cns\Temporary;
+use Brazanation\Documents\Cns\TemporaryCalculator;
 
 final class Cns extends AbstractDocument
 {
@@ -17,11 +17,6 @@ final class Cns extends AbstractDocument
 
     const DIGIT_COUNT = 1;
 
-    /**
-     * @var DigitCalculable
-     */
-    private $calculator;
-
     /**
      * CNS constructor.
      *
@@ -30,18 +25,9 @@ final class Cns extends AbstractDocument
     public function __construct($number)
     {
         $number = preg_replace('/\D/', '', $number);
-        $this->defineCalculator($number);
         parent::__construct($number, self::LENGTH, self::DIGIT_COUNT, self::LABEL);
     }
 
-    public function defineCalculator($number)
-    {
-        $this->calculator = new CnsCalculator();
-        if (in_array(substr($number, 0, 1), [7, 8, 9])) {
-            $this->calculator = new Temporary($number);
-        }
-    }
-
     /**
      * {@inheritdoc}
      */
@@ -52,10 +38,21 @@ public function format()
 
     /**
      * {@inheritdoc}
+     *
+     * Based on given number, it will decide what kind of calculator will use.
+     *
+     * For numbers starting with 7, 8 or 9 will use TemporaryCalculator,
+     * otherwise CnsCalculator.
      */
     public function calculateDigit($baseNumber)
     {
-        $digit = $this->calculator->calculateDigit($baseNumber);
+        $calculator = new CnsCalculator();
+
+        if (in_array(substr($baseNumber, 0, 1), [7, 8, 9])) {
+            $calculator = new TemporaryCalculator();
+        }
+
+        $digit = $calculator->calculateDigit($baseNumber);
 
         return "{$digit}";
     }

src/Cns/Temporary.php renamed to src/Cns/TemporaryCalculator.php

@@ -5,7 +5,7 @@
 use Brazanation\Documents\DigitCalculable;
 use Brazanation\Documents\DigitCalculator;
 
-class Temporary implements DigitCalculable
+class TemporaryCalculator implements DigitCalculable
 {
     /**
      * {@inheritdoc}